Updating docs to reflect LayerCI changes to webapp.io #5632
Conversation
👷 Deploy request for cypress-docs pending review.Visit the deploys page to approve it
|
✅ Deploy Preview for benevolent-cat-040f48 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
|
|
|
|
@MikeMcC399 Good point outs. We can address those concerns seperately. |
| @@ -454,6 +454,10 @@ to see why the commit information is unavailable. | |||
| DEBUG=commit-info,cypress:server:record | |||
| ``` | |||
|
|
|||
| :::info | |||
| Cypress versions less than 3.15.0 will need to manually provide the CI ENVs to correctly send their SCM to the Cloud | |||
There was a problem hiding this comment.
This is not a valid Cypress version. I'm not sure what @emilyrohrbough was trying to convey in their original comment. I think she meant the version that this is released in? cypress-io/cypress#28577 (comment)
There was a problem hiding this comment.
The latest Cypress 3.x version released was cypress@3.8.3 in Jan 2020, so I would not have thought it is necessary to draw attention to such an old and legacy version.
With the exception of the Configuration (Legacy) page and the Migration Guide it is more or less assumed that the user has at the minimum Cypress 10.x if not Cypress 13.x running.
There was a problem hiding this comment.
@joshuadsouza are you able to make these updates?
| @@ -179,5 +179,5 @@ and | |||
|
|
|||
| ### webapp.io | |||
|
|
|||
| - [cypress-example-layerci](https://github.com/bahmutov/cypress-example-layerci) | |||
| - [Using cypress with webapp.io](https://webapp.io/docs/integrations/cypress) | |||
| - [Basic Example (Layerfile)](https://github.com/webappio/react-e2e-example/blob/master/Layerfile) | |||
There was a problem hiding this comment.
The whole point of me asking for this update was so that we don't have to specify --ci-build-id on the cypress command, but if I upgrade to 13.6.5 and remove the flag in Webapp.io, I get the error:
{
"message": "CI Build ID could not be generated and was not specified.",
"code": "INDETERMINATE_CI_BUILD_ID"
}
@jennifer-shehane Could we perhaps setup a cloud account for Webapp.io for testing purposes and then @joshuadsouza could update the example above to use the --record flag and thus verify that this integration works as expected with Cypress Cloud?
I'm really trying to remove the use of --ci-build-id because it makes the command non-deterministic and messes up the content-aware caching I'm trying to setup with Turborepo.
There was a problem hiding this comment.
@ianwalter Could you open a new issue in the cypress repo? I think we may need to make a Cloud change to address this, but it won't be tracked well as a comment in this PR.
There was a problem hiding this comment.
LayerCI rebranded to webapp.io, context here: https://webapp.io/blog/layerci-has-rebranded-to-webapp-io/
This PR does the following: