-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates for events overhaul #967
Conversation
- update plugins -> background - create Catalog of Events table - break out events into own pages - make browser and background events conform to same format - add Usage section to all browser events
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some surface level review comments.
I'm only about halfway through this mega PR 😫I'll likely have some deeper commentary after I've slept on it.
😄
Good stuff though! I'm learning a lot 🙇
|
||
# Usage | ||
|
||
This example demonstrates testing that your application was redirected |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a final period to end the sentence.
- since the next link is a redirect, it breaks the pagination.
- rearranging sentences to read better mostly
- remove ‘Event’ from title - Add chart for each environment showing checkmarks for where it works - Add links to headers of event table - Add missing environment from task event doc - fix mis-alphabetization of sidebar
- Have all arguments follow same format for command args.
- always specify where usage takes place - break out examples vs usage - always have usage below arguments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made a bunch of updates to mostly normalize the views across all of the events.
Have a couple other things that needed addressing.
The only other thing that nags me is this use of the word "Environment" for background vs browser, especially since this has many different meanings within Cypress. Is it possible to rename this to something more precise. Context maybe?
I understand the concern about "environment", but I'm not sure "context" is any better. It's a pretty vague term. Maybe "process" as in browser process and background process, but browser process sounds kind of weird to me. Need to come up with something since we'll probably use it extensively when we create the 'Architecture' guide that describes the browser/background processes/contexts/environments... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Document log event changes
…ed-error add error message for mocha overspecified error
TODO
Closes #890