test spy retries, close #86

[bahmutov]

Failing test case for spy retries

[brian-mann]

Oomphf - I think these types of tests should go in the driver's integration tests. Unless there is some observable and explainable value to users it does not belong in recipes.

[bahmutov]

Maybe but I think users would benefit from three ways of spying example !

…

Sent from my iPhone

On Jan 5, 2018, at 14:58, Brian Mann ***@***.***> wrote: Oomphf - I think these types of tests should go in the driver's integration tests. Unless there is some observable and explainable value to users it does not belong in recipes. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

[brian-mann]

I agree - but this should just go into the docs. Since it's not actually testing a "real" scenario - we could just add these as a simple "Notes" or "Example" in the docs in the spying/stubbing guide.

[bahmutov]

Ok here and into docs.

…

Sent from my iPhone

On Jan 5, 2018, at 15:01, Brian Mann ***@***.***> wrote: I agree - but this should just go into the docs. Since it's not actually testing a "real" scenario - we could just add these as a simple "Notes" or "Example" in the docs in the spying/stubbing guide. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

[brian-mann]

Closing this - as these tests are in the driver - I believe they belong there. Recipes are about achieving real world use cases and not general purpose. If we could bake these into the recipes in a useful way I'd pull in.