allow firefoxGcInterval = 0 to disable

cypress-io · Jan 23, 2020 · 19816f7 · 19816f7 · cypress-bot · Jan 23, 2020
1 parent d22de38
commit 19816f7
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/cli/types/index.d.ts b/cli/types/index.d.ts
@@ -298,7 +298,7 @@ declare namespace Cypress {
  /**
  * Firefox only: Get the current number of tests that will run between forced garbage collections.
  *
- * Returns undefined if not in Firefox, returns a null if forced GC is disabled.
+ * Returns undefined if not in Firefox, returns a null or 0 if forced GC is disabled.
  *
  * @see https://on.cypress.io/firefox-gc-issue
  */
@@ -2243,7 +2243,7 @@ declare namespace Cypress {
  /**
  * Firefox-only: The number of tests that will run between forced garbage collections.
  * If a number is supplied, it will apply to `run` mode and `open` mode.
- * Set the interval to `null` to disable forced garbage collections.
+ * Set the interval to `null` or 0 to disable forced garbage collections.
  * @default { runMode: 1, openMode: null }
  */
  firefoxGcInterval: Nullable<number | { runMode: Nullable<number>, openMode: Nullable<number> }>

diff --git a/packages/server/lib/util/validation.js b/packages/server/lib/util/validation.js
@@ -105,7 +105,7 @@ const isValidBrowserList = (key, browsers) => {
 const isValidFirefoxGcInterval = (key, value) => {
  const isIntervalValue = (val) => {
  if (isNumber(val)) {
- return val > 0
+ return val >= 0
  }
 
  return val == null
@@ -118,7 +118,7 @@ const isValidFirefoxGcInterval = (key, value) => {
  return true
  }
 
- return errMsg(key, value, 'a positive, non-zero number or null or an object with "openMode" and "runMode" as keys and positive, non-zero numbers or nulls as values')
+ return errMsg(key, value, 'a positive number or null or an object with "openMode" and "runMode" as keys and positive numbers or nulls as values')
 }
 
 module.exports = {