Skip to content

Commit

Permalink
fix: issue-7715 (#23575)
Browse files Browse the repository at this point in the history
Co-authored-by: Chris Breiding <chrisbreiding@gmail.com>
  • Loading branch information
rachelruderman and chrisbreiding authored Sep 9, 2022
1 parent afb8e67 commit 406eb06
Show file tree
Hide file tree
Showing 18 changed files with 83 additions and 396 deletions.
18 changes: 8 additions & 10 deletions packages/app/cypress/e2e/runner/reporter.errors.cy.ts
Original file line number Diff line number Diff line change
Expand Up @@ -34,27 +34,24 @@ describe('errors ui', {
})

verify('with expect().<foo>', {
line: 3,
column: 25,
message: `expected 'actual' to equal 'expected'`,
verifyOpenInIde: true,
ideLine: 3,
ideColumn: 25,
})

verify('with assert()', {
column: '(5|12)', // (chrome|firefox)
line: 7,
column: [5, 12], // [chrome, firefox]
message: `should be true`,
verifyOpenInIde: true,
ideLine: 7,
ideColumn: 5,
})

verify('with assert.<foo>()', {
line: 11,
column: 12,
message: `expected 'actual' to equal 'expected'`,
verifyOpenInIde: true,
ideLine: 11,
ideColumn: 12,
})
})

Expand Down Expand Up @@ -85,7 +82,8 @@ describe('errors ui', {

verify('in file outside project', {
message: 'An outside error',
regex: /\/throws\-error\.js:5:9/,
stackRegex: /\/throws\-error\.js:5:8/,
codeFrameRegex: /\/throws\-error\.js:5:9/,
codeFrameText: `thrownewError('An outside error')`,
})
})
Expand All @@ -100,7 +98,7 @@ describe('errors ui', {
// https://github.com/cypress-io/cypress/issues/8288
// https://github.com/cypress-io/cypress/issues/8350
verify('test', {
column: '(7|18)', // (chrome|firefox)
column: [7, 18], // [chrome, firefox]
codeFrameText: 'beforeEach(()=>',
message: `Cypress detected you registered a(n) beforeEach hook while a test was running`,
})
Expand Down Expand Up @@ -483,7 +481,7 @@ describe('errors ui', {
})

verify('from chai expect', {
column: '(5|12)', // (chrome|firefox)
column: [5, 12], // [chrome, firefox]
message: 'Invalid Chai property: nope',
stack: ['proxyGetter', 'From Your Spec Code:'],
})
Expand Down
2 changes: 1 addition & 1 deletion packages/app/cypress/e2e/runner/reporter.hooks.cy.ts
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ describe('hooks', {

cy.withCtx((ctx, o) => {
expect(ctx.actions.file.openFile).to.have.been.calledWith(o.sinon.match(new RegExp(`hooks/basic\.cy\.js$`)), o.ideLine, o.ideColumn)
}, { ideLine: 2, ideColumn: Cypress.browser.family === 'firefox' ? 6 : 3 })
}, { ideLine: 2, ideColumn: Cypress.browser.family === 'firefox' ? 5 : 2 })
})

it('does not display commands from skipped tests', () => {
Expand Down
Loading

4 comments on commit 406eb06

@cypress-bot
Copy link
Contributor

@cypress-bot cypress-bot bot commented on 406eb06 Sep 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Circle has built the linux x64 version of the Test Runner.

Learn more about this pre-release platform-specific build at https://on.cypress.io/installing-cypress#Install-pre-release-version.

Run this command to install the pre-release locally:

npm install https://cdn.cypress.io/beta/npm/10.8.0/linux-x64/develop-406eb069a6d98b66ed087c5456a70938153f265a/cypress.tgz

@cypress-bot
Copy link
Contributor

@cypress-bot cypress-bot bot commented on 406eb06 Sep 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Circle has built the linux arm64 version of the Test Runner.

Learn more about this pre-release platform-specific build at https://on.cypress.io/installing-cypress#Install-pre-release-version.

Run this command to install the pre-release locally:

npm install https://cdn.cypress.io/beta/npm/10.8.0/linux-arm64/develop-406eb069a6d98b66ed087c5456a70938153f265a/cypress.tgz

@cypress-bot
Copy link
Contributor

@cypress-bot cypress-bot bot commented on 406eb06 Sep 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Circle has built the darwin x64 version of the Test Runner.

Learn more about this pre-release platform-specific build at https://on.cypress.io/installing-cypress#Install-pre-release-version.

Run this command to install the pre-release locally:

npm install https://cdn.cypress.io/beta/npm/10.8.0/darwin-x64/develop-406eb069a6d98b66ed087c5456a70938153f265a/cypress.tgz

@cypress-bot
Copy link
Contributor

@cypress-bot cypress-bot bot commented on 406eb06 Sep 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Circle has built the darwin arm64 version of the Test Runner.

Learn more about this pre-release platform-specific build at https://on.cypress.io/installing-cypress#Install-pre-release-version.

Run this command to install the pre-release locally:

npm install https://cdn.cypress.io/beta/npm/10.8.0/darwin-arm64/develop-406eb069a6d98b66ed087c5456a70938153f265a/cypress.tgz

Please sign in to comment.