refactor: CriClient -> traditional class + async factory (#29676)

* refactor: CriClient -> traditional class + async factory

* Update packages/server/test/unit/browsers/cri-client_spec.ts

* member fns of CriClient must be bound to context

* rethrow debug-inspected ws send error

* make cri client constructor private to force factory method; ref cri connection via closure

* add todo for potential memory leak in CriClient

packages/server/lib/browsers/browser-cri-client.ts

@@ -5,7 +5,7 @@ import Debug from 'debug'
 import type { Protocol } from 'devtools-protocol'
 import { _connectAsync, _getDelayMsForRetry } from './protocol'
 import * as errors from '../errors'
-import { create, CriClient, DEFAULT_NETWORK_ENABLE_OPTIONS } from './cri-client'
+import { CriClient, DEFAULT_NETWORK_ENABLE_OPTIONS } from './cri-client'
 import { serviceWorkerClientEventHandler, serviceWorkerClientEventHandlerName } from '@packages/proxy/lib/http/util/service-worker-manager'
 import type { ProtocolManagerShape } from '@packages/types'
 import type { ServiceWorkerEventHandler } from '@packages/proxy/lib/http/util/service-worker-manager'
@@ -241,7 +241,7 @@ export class BrowserCriClient {
  return retryWithIncreasingDelay(async () => {
  const versionInfo = await CRI.Version({ host, port, useHostName: true })
 
- const browserClient = await create({
+ const browserClient = await CriClient.create({
  target: versionInfo.webSocketDebuggerUrl,
  onAsynchronousError,
  onReconnect,
@@ -543,7 +543,7 @@ export class BrowserCriClient {
  throw new Error(`Could not find url target in browser ${url}. Targets were ${JSON.stringify(targets)}`)
  }
 
- this.currentlyAttachedTarget = await create({
+ this.currentlyAttachedTarget = await CriClient.create({
  target: target.targetId,
  onAsynchronousError: this.onAsynchronousError,
  host: this.host,
@@ -603,7 +603,7 @@ export class BrowserCriClient {
  })
 
  if (target) {
- this.currentlyAttachedTarget = await create({
+ this.currentlyAttachedTarget = await CriClient.create({
  target: target.targetId,
  onAsynchronousError: this.onAsynchronousError,
  host: this.host,

packages/server/lib/browsers/cdp_automation.ts

@@ -144,7 +144,7 @@ export type SendDebuggerCommand = <T extends CdpCommand>(message: T, data?: Prot
 
 export type OnFn = <T extends CdpEvent>(eventName: T, cb: (data: ProtocolMapping.Events[T][0], sessionId?: string) => void) => void
 
-export type OffFn = (eventName: string, cb: (data: any) => void) => void
+export type OffFn = <T extends CdpEvent>(eventName: T, cb: (data: any) => void) => void
 
 type SendCloseCommand = (shouldKeepTabOpen: boolean) => Promise<any> | void
 interface HasFrame {