chore: [multi-domain] clean up the sync:globals event in the event of…

… errors
cypress-io · Mar 28, 2022 · 68b1dc9 · 68b1dc9
1 parent 453d1ca
commit 68b1dc9
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/packages/driver/src/cy/multi-domain/index.ts b/packages/driver/src/cy/multi-domain/index.ts
@@ -102,6 +102,7 @@ export function addCommands (Commands, Cypress: Cypress.Cypress, cy: Cypress.cy,
  return new Bluebird((resolve, reject, onCancel) => {
  const cleanup = () => {
  communicator.off('queue:finished', onQueueFinished)
+ communicator.off('sync:globals', onSyncGlobals)
  }
 
  onCancel && onCancel(() => {
@@ -127,10 +128,12 @@ export function addCommands (Commands, Cypress: Cypress.Cypress, cy: Cypress.cy,
  _resolve({ subject, unserializableSubjectType })
  }
 
- communicator.once('sync:globals', ({ config, env }) => {
+ const onSyncGlobals = ({ config, env }) => {
  syncConfigToCurrentDomain(config)
  syncEnvToCurrentDomain(env)
- })
+ }
+
+ communicator.once('sync:globals', onSyncGlobals)
 
  communicator.once('ran:domain:fn', (details) => {
  const { subject, unserializableSubjectType, err, finished } = details