Skip to content

Commit

Permalink
Revert "remove instruction to update electron version in centos 7 step"
Browse files Browse the repository at this point in the history
This reverts commit 01131cf.
  • Loading branch information
jennifer-shehane committed Oct 2, 2024
1 parent d61695b commit c884f94
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions packages/electron/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ Upgrading `electron` involves more than just bumping this package's `package.jso
- The [NodeJS](https://nodejs.org/en) version is not the active LTS.
- [ ] **Update `workflows.yml`**
- [ ] Ensure it references the new `base-internal` and `browsers-internal` Docker images
- [ ] Ensure the new Electron version is used as a build target in the `Build better-sqlite3 for CentOS 7` step

- [ ] **Ensure that a matching Node.js version is enforced in the monorepo for local development and CI.** When Electron is upgraded, oftentimes, the bundled Node.js version that comes with Electron is updated as well. Because all unit and integration tests run in normal Node.js (not Electron's Node.js), it's important for this Node.js version to be synced with the monorepo. There are a few places where this needs to be done:
- [ ] [`/.node-version`](../../.node-version) - used by `nvm` and other Node version managers
Expand Down

0 comments on commit c884f94

Please sign in to comment.