chore: [Multi-domain] Reset timeout after transition from before to…

… `it` while unstable. (#21032)

* chore: [Multi-domain] Reset timeout after transition from before block to it block while unstable.

* enable clear timeout

* Adding tests and a comment

* Update packages/driver/src/cypress/command_queue.ts

Co-authored-by: Chris Breiding <chrisbreiding@users.noreply.github.com>

* Move tests to their own file.

Co-authored-by: Chris Breiding <chrisbreiding@users.noreply.github.com>

packages/driver/cypress/integration/e2e/stability_spec.js

@@ -0,0 +1,32 @@
+describe('stability', () => {
+ describe('transitioning from a before block to an it block while unstable', () => {
+ beforeEach(() => {
+ cy.visit('/fixtures/auth/index.html')
+ cy.window().then((win) => {
+ win.location.href = 'http://localhost:3500/timeout?ms=1000'
+ })
+ })
+
+ it('fails if the page does not load within the page load timeout', { defaultCommandTimeout: 50, pageLoadTimeout: 500 }, (done) => {
+ cy.on('fail', (err) => {
+ expect(err.message).to.include(`Timed out after waiting \`500ms\` for your remote page to load.`)
+ done()
+ })
+
+ cy.get('[data-cy="login-idp"]').click() // Takes you to idp.com
+ })
+
+ it('waits for the page to load before running the command', { defaultCommandTimeout: 50 }, () => {
+ cy.get('body').invoke('text').should('equal', 'timeout')
+ })
+
+ it('will retry and fail the command after the page loads', { defaultCommandTimeout: 50 }, (done) => {
+ cy.on('fail', (err) => {
+ expect(err.message).to.include(`Timed out retrying after 50ms: expected 'timeout' to equal 'not timeout'`)
+ done()
+ })
+
+ cy.get('body').invoke('text').should('equal', 'not timeout')
+ })
+ })
+})

packages/driver/src/cypress/command_queue.ts

@@ -316,6 +316,12 @@ export class CommandQueue extends Queue<Command> {
  // store the previous timeout
  const prevTimeout = this.timeout()
 
+ // If we have created a timeout but are in an unstable state, clear the
+ // timeout in favor of the on load timeout already running.
+ if (!cy.state('isStable')) {
+ cy.clearTimeout()
+ }
+
  // store the current runnable
  const runnable = this.state('runnable')