restore visibility algo, update test for ff

cypress-io · Jan 2, 2020 · de9c388 · de9c388 · cypress-bot · Jan 2, 2020
1 parent 5de7a11
commit de9c388
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/packages/driver/src/dom/visibility.js b/packages/driver/src/dom/visibility.js
@@ -359,16 +359,16 @@ const elIsOutOfBoundsOfAncestorsOverflow = function ($el, $ancestor = $el.parent
  // target el is out of bounds
  if (
  // target el is to the right of the ancestor's visible area
- (elProps.fromElWindow.left >= (ancestorProps.width + ancestorProps.fromElWindow.left)) ||
+ (elProps.fromElWindow.left > (ancestorProps.width + ancestorProps.fromElWindow.left)) ||
 
  // target el is to the left of the ancestor's visible area
- ((elProps.fromElWindow.left + elProps.width) <= ancestorProps.fromElWindow.left) ||
+ ((elProps.fromElWindow.left + elProps.width) < ancestorProps.fromElWindow.left) ||
 
  // target el is under the ancestor's visible area
- (elProps.fromElWindow.top >= (ancestorProps.height + ancestorProps.fromElWindow.top)) ||
+ (elProps.fromElWindow.top > (ancestorProps.height + ancestorProps.fromElWindow.top)) ||
 
  // target el is above the ancestor's visible area
- ((elProps.fromElWindow.top + elProps.height) <= ancestorProps.fromElWindow.top)
+ ((elProps.fromElWindow.top + elProps.height) < ancestorProps.fromElWindow.top)
  ) {
  return true
  }

diff --git a/packages/driver/test/cypress/integration/dom/visibility_spec.js b/packages/driver/test/cypress/integration/dom/visibility_spec.js
@@ -362,7 +362,7 @@ describe('src/cypress/dom/visibility', () => {
 <div style='width: 100px; height: 100px; overflow: hidden; position: relative; top: 700px; left: 700px;'>
  <div style='position: absolute;'>
  <div style='position: absolute;'>
- <span style='position: absolute; left: -300px; top: 0px;'>out of bounds, parent position: absolute</span>
+ <span style='position: absolute; left: -350px; top: 0px;'>out of bounds, parent position: absolute</span>
  </div>
  </div>
 </div>\