fix cy.visit error stack, magenta e2e test stdout, bump zip

packages/driver/src/cy/commands/navigation.coffee

@@ -793,6 +793,7 @@ module.exports = (Commands, Cypress, cy, state, config) ->
  error: err
  stack: err.stack
  }
+ noStackTrace: true
  })
 
  visit = ->

packages/driver/src/cypress/cy.coffee

@@ -643,6 +643,11 @@ create = (specWindow, Cypress, Cookies, state, config, log) ->
  ## collect all of the callbacks for 'fail'
  rets = Cypress.action("cy:fail", err, state("runnable"))
  catch err2
+ e = err2
+ errString = e.toString()
+ errStack = e.stack
+ if !errStack.slice(0, errStack.indexOf("\n")).includes(errString)
+ e.stack = errString + "\n" + e.stack
  ## and if any of these throw synchronously immediately error
  finish(err2)
 

packages/driver/src/cypress/utils.coffee

@@ -117,6 +117,8 @@ module.exports = {
  throwErr: (err, options = {}) ->
  if _.isString(err)
  err = @cypressErr(err)
+ if options.noStackTrace
+ err.stack = ''
 
  onFail = options.onFail
  errProps = options.errProps

packages/server/test/support/helpers/e2e.coffee

@@ -7,6 +7,8 @@ path = require("path")
 http = require("http")
 human = require("human-interval")
 morgan = require("morgan")
+stream = require("stream")
+chalk = require("chalk").default
 express = require("express")
 Promise = require("bluebird")
 snapshot = require("snap-shot-it")
@@ -38,18 +40,20 @@ DEFAULT_BROWSERS = ['electron', 'chrome', 'firefox']
 stackTraceLinesRe = /(\n?\s*).*?(@|at).*\.(js|coffee|ts|html|jsx|tsx)(-\d+)?:\d+:\d+[\n\S\s]*?(\n\s*?\n|$)/g
 browserNameVersionRe = /(Browser\:\s+)(Custom |)(Electron|Chrome|Canary|Chromium|Firefox)(\s\d+)(\s\(\w+\))?(\s+)/
 availableBrowsersRe = /(Available browsers found are: )(.+)/g
+crossOriginErrorRe = /(Blocked a frame .* from accessing a cross-origin frame|Permission denied.*cross-origin object)/gm
 
 currentOptions = {}
 
 ## this captures an entire stack trace and replaces it with [stack trace lines]
 ## so that the stdout can contain stack traces of different lengths
 ## '@' will be present in firefox stack trace lines
 ## 'at' will be present in chrome stack trace lines
-replaceStackTraceLines = (str, browser) ->
+replaceStackTraceLines = (str) ->
  str.replace(stackTraceLinesRe, (match, parts...) ->
  pre = parts[0]
+ isFirefoxStack = parts[1] is '@'
  post = parts[4]
- if browser is 'firefox'
+ if isFirefoxStack
  if pre is '\n'
  pre = '\n '
  else
@@ -58,6 +62,10 @@ replaceStackTraceLines = (str, browser) ->
  post = post.slice(-1)
  return "#{pre}[stack trace lines]#{post}")
 
+## Different browsers have different cross-origin error messages
+replaceCrossOriginErorrMessages = (str) ->
+ str.replace crossOriginErrorRe, '[Cross origin error message]'
+
 replaceBrowserName = (str, key, customBrowserPath, browserName, version, headless, whitespace) ->
  ## get the padding for the existing browser string
  lengthOfExistingBrowserString = _.sum([browserName.length, version.length, _.get(headless, "length", 0), whitespace.length])
@@ -144,7 +152,7 @@ normalizeStdout = (str) ->
  ## screenshot dimensions
  str = str.replace(/(\(\d+x\d+\))/g, replaceScreenshotDims)
 
- return replaceStackTraceLines(str, options.browser)
+ return replaceStackTraceLines( replaceCrossOriginErorrMessages str)
 
 ensurePort = (port) ->
  if port is 5566
@@ -539,10 +547,16 @@ module.exports = e2e = {
  .value()
  }
 
+ ColorOutput = () ->
+ colorOutput = new stream.Transform()
+ colorOutput._transform = (chunk, encoding, cb) ->
+ cb(null, chalk.magenta(chunk.toString()))
+ colorOutput
+
  ## pipe these to our current process
  ## so we can see them in the terminal
- sp.stdout.pipe(process.stdout)
- sp.stderr.pipe(process.stderr)
+ sp.stdout.pipe(ColorOutput()).pipe(process.stdout)
+ sp.stderr.pipe(ColorOutput()).pipe(process.stderr)
 
  sp.stdout.on "data", (buf) ->
  stdout += buf.toString()

scripts/binary/zip.coffee

@@ -39,7 +39,7 @@ checkZipSize = (zipPath) ->
  stats = fs.statSync(zipPath)
  zipSize = filesize(stats.size, {round: 0})
  console.log("zip file size #{zipSize}")
- MAX_ALLOWED_SIZE_MB = if os.platform() == "win32" then 275 else 180
+ MAX_ALLOWED_SIZE_MB = if os.platform() == "win32" then 275 else 185
  MAX_ZIP_FILE_SIZE = megaBytes(MAX_ALLOWED_SIZE_MB)
  if stats.size > MAX_ZIP_FILE_SIZE
  throw new Error("Zip file is too large: #{zipSize} (#{stats.size} bytes) exceeds #{MAX_ZIP_FILE_SIZE} bytes")