add stubbed out tests for cy-in-cy and correct documentation

cypress-io · Jan 11, 2022 · e4921c2 · e4921c2
1 parent 336827f
commit e4921c2
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/packages/driver/cypress/integration/e2e/multi_domain_spec.ts b/packages/driver/cypress/integration/e2e/multi_domain_spec.ts
@@ -316,5 +316,9 @@ describe('multi-domain', { experimentalSessionSupport: true, experimentalMultiDo
  it('propagates user defined secondary domain errors to the primary')
 
  it('short circuits the secondary domain command queue when "done()" is called early')
+
+ it('does not have pending commands in the ui invoked from switchToDomain when tests passes')
+
+ it('does not have pending commands in the ui invoked from switchToDomain when tests fail')
  })
 })
diff --git a/packages/driver/src/cy/multi-domain/index.ts b/packages/driver/src/cy/multi-domain/index.ts
@@ -200,10 +200,11 @@ export function addCommands (Commands, Cypress: Cypress.Cypress, cy: Cypress.cy,
  }
 
  const doneAndCleanup = async (err) => {
- // if done is called, immediately unbind commands, but wait for log updates to trickle in before invoking done
+ communicator.off('done:called', doneAndCleanup)
+
+ // if done is called, immediately unbind commands to prevent any commands from being enqueued, but wait for log updates to trickle in before invoking done
  cleanupCommands()
  await cleanupLogs()
- communicator.off('done:called', doneAndCleanup)
  done(err)
  }