fix: close chrome when closing electron (#19322)

cypress-io · Dec 9, 2021 · f79bdd6 · f79bdd6 · cypress-bot · Dec 9, 2021
1 parent 65cf6e8
commit f79bdd6
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 7 deletions.
diff --git a/packages/server/lib/browsers/chrome.ts b/packages/server/lib/browsers/chrome.ts
@@ -520,13 +520,13 @@ export = {
     const originalBrowserKill = launchedBrowser.kill
 
     /* @ts-expect-error */
-    launchedBrowser.kill = async (...args) => {
+    launchedBrowser.kill = (...args) => {
       debug('closing remote interface client')
 
-      await criClient.close()
+      criClient.close()
       debug('closing chrome')
 
-      await originalBrowserKill.apply(launchedBrowser, args)
+      originalBrowserKill.apply(launchedBrowser, args)
     }
 
     await this._maybeRecordVideo(criClient, options, browser.majorVersion)

diff --git a/packages/server/lib/browsers/cri-client.ts b/packages/server/lib/browsers/cri-client.ts
@@ -191,7 +191,6 @@ export const create = Bluebird.method((target: websocketUrl, onAsynchronousError
       maybeDebugCdpMessages(cri)
 
       cri.send = Bluebird.promisify(cri.send, { context: cri })
-      cri.close = Bluebird.promisify(cri.close, { context: cri })
 
       // @see https://github.com/cyrus-and/chrome-remote-interface/issues/72
       cri._notifier.on('disconnect', reconnect)

diff --git a/packages/server/test/unit/browsers/chrome_spec.js b/packages/server/test/unit/browsers/chrome_spec.js
@@ -300,10 +300,9 @@ describe('lib/browsers/chrome', () => {
       .then(() => {
         expect(this.launchedBrowser.kill).to.be.a('function')
 
-        return this.launchedBrowser.kill()
-      }).then(() => {
-        expect(this.criClient.close).to.be.calledOnce
+        this.launchedBrowser.kill()
 
+        expect(this.criClient.close).to.be.calledOnce
         expect(kill).to.be.calledOnce
       })
     })