fix: remove inner scroll from BaseError (#20104)

cypress-io · Feb 11, 2022 · faa8fb5 · faa8fb5 · cypress-bot · Feb 11, 2022
1 parent 5c5f5d5
commit faa8fb5
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 5 deletions.
diff --git a/packages/frontend-shared/src/components/Alert.vue b/packages/frontend-shared/src/components/Alert.vue
@@ -4,11 +4,11 @@
     lazy
     :initially-open="initiallyOpen"
     :disable="!canCollapse"
-    class="rounded-t rounded-b outline-none overflow-hidden group"
+    class="overflow-hidden rounded-t rounded-b outline-none group"
     :class="[
       classes.headerClass,
       {[`hocus-default border-1 border-transparent rounded ${classes.ring}`]: canCollapse}]"
-    height="300"
+    :max-height="maxHeight"
   >
     <template #target="{ open }">
       <div
@@ -98,7 +98,8 @@ const props = withDefaults(defineProps<{
   dismissible?: boolean,
   collapsible?: boolean,
   modelValue?: boolean,
-  iconClasses?: string
+  iconClasses?: string,
+  maxHeight?: string,
 }>(), {
   title: undefined,
   modelValue: true,
@@ -107,6 +108,7 @@ const props = withDefaults(defineProps<{
   headerClass: undefined,
   bodyClass: undefined,
   iconClasses: '',
+  maxHeight: undefined,
 })
 
 const title = computed(() => props.title ?? 'Alert')

diff --git a/packages/launchpad/src/error/BaseError.vue b/packages/launchpad/src/error/BaseError.vue
@@ -1,5 +1,5 @@
 <template>
-  <div class="mx-auto space-y-32px text-center min-w-476px max-w-848px pt-16px children:text-center">
+  <div class="mx-auto space-y-32px text-center min-w-476px max-w-848px py-16px children:text-center">
     <div>
       <h1
         class="font-medium leading-snug text-32px text-gray-900"
@@ -30,6 +30,7 @@
           header-class="bg-red-100 text-red-600 rounded-b-none"
           :icon="ErrorOutlineIcon"
           icon-classes="icon-dark-red-400"
+          max-height="none"
         >
           <p
             v-if="errorMessage"
@@ -43,7 +44,7 @@
           >
             <Collapsible
               disable
-              max-height="400px"
+              max-height="none"
               initially-open
             >
               <template #target="{open, toggle}">