Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend plugins to enable returning a promise and/or mutating config #1042

Closed
brian-mann opened this issue Dec 8, 2017 · 3 comments
Closed

Extend plugins to enable returning a promise and/or mutating config #1042

brian-mann opened this issue Dec 8, 2017 · 3 comments
Assignees
@brian-mann
Milestone
1.2.0

Comments

@brian-mann
Copy link
Member

Plugins are currently expected to return synchronously and bind to events.

Even though config is yielded, it is unmutable (we disregard the return value)

This feature will enable users to:

  • Add async events to the plugins function
  • Eventually resolve with a modified config object
  • Programmatically alter config values or env vars

We'll need to also take this into account with the resolved values of config, and make sure we display them as the source in the Desktop GUI
@brian-mann brian-mann added this to the 1.2.0 milestone Dec 8, 2017
@brian-mann brian-mann self-assigned this Dec 8, 2017
@iGitScor
Copy link

iGitScor commented Dec 8, 2017

The 3rd point is so freaking awesome 👏 👌

This was referenced Dec 8, 2017
Closed
Closed
brian-mann added a commit that referenced this issue Dec 11, 2017
@brian-mann
fixes #1042 enable plugins to return a promise and modify config
0e07d80
@brian-mann
Copy link
Member Author

We now show config + env values overridden from plugins.

screen shot 2017-12-10 at 11 01 30 pm

@brian-mann
Copy link
Member Author

Released in 1.2.0.

@noahblon noahblon mentioned this issue Nov 27, 2023
Open
@ajesse11x ajesse11x mentioned this issue Nov 28, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brian-mann brian-mann

Labels
None yet
Projects
None yet
Milestone
1.2.0
Development

No branches or pull requests
2 participants
@brian-mann @iGitScor