Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix warning when projectRoot is not writable #18485

Closed
flotwig opened this issue Oct 13, 2021 · 2 comments · Fixed by #18495
Closed

Fix warning when projectRoot is not writable #18485

flotwig opened this issue Oct 13, 2021 · 2 comments · Fixed by #18495
Assignees
@elevatebart
Labels
type: regression A bug that didn't appear until a specific Cy version release v8.6.0 🐛 Issue present since 8.6.0

Comments

@flotwig
Copy link
Contributor

flotwig commented Oct 13, 2021

Current behavior

In this PR, Cypress was modified to allow running on a read-only filesystem: #7126

The behavior was changed to warn with the 'FOLDER_NOT_WRITABLE' message, instead of erroring out, if the root was unwriteable for videos/screenshots.

In this PR, the warning emit was removed: #18221

The error still exists in the code, but is not being properly emitted.

This regression went unnoticed for a long time because this system test was failing but was not visible due to a bug with snapshots not failing system tests, but now it exposes the failure: https://app.circleci.com/pipelines/github/cypress-io/cypress/24915/workflows/1af6c0d9-6858-4d67-89b2-31e25e49ad9e/jobs/930321

image

Desired behavior

Cypress should warn when running on a read-only filesystem.

Test code to reproduce

Unskip the test skipped in #16354 and run:

yarn workspace @internal/system-tests test non_root_read_only_fs_spec

Cypress Version

latest develop

Other

No response
@flotwig flotwig added the type: regression A bug that didn't appear until a specific Cy version release label Oct 13, 2021
@flotwig flotwig mentioned this issue Oct 14, 2021
Merged
1 task
elevatebart added a commit that referenced this issue Oct 14, 2021
@elevatebart
fix: warn when the projectRoot is not writeable
6889b11 
closes #18485
@elevatebart elevatebart mentioned this issue Oct 14, 2021
Merged
1 task
@cypress-bot cypress-bot bot added stage: work in progress stage: needs review The PR code is done & tested, needs review and removed stage: work in progress labels Oct 14, 2021
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Oct 14, 2021

The code for this is done in cypress-io/cypress#18495, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

elevatebart pushed a commit that referenced this issue Oct 14, 2021
fix: warn when the projectRoot is not writeable (#18495)
83a1f09 
closes #18485
@cypress-bot cypress-bot bot added stage: pending release and removed stage: needs review The PR code is done & tested, needs review labels Oct 14, 2021
@jennifer-shehane jennifer-shehane added the v8.6.0 🐛 Issue present since 8.6.0 label Oct 21, 2021
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Oct 25, 2021

Released in 8.7.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v8.7.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Oct 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@elevatebart elevatebart

Labels
type: regression A bug that didn't appear until a specific Cy version release v8.6.0 🐛 Issue present since 8.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: warn when the projectRoot is not writeable cypress-io/cypress
3 participants
@flotwig @jennifer-shehane @elevatebart