Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Multi-Domain] Support cy.screenshot #20060

Closed
mschile opened this issue Feb 4, 2022 · 2 comments · Fixed by #20119, #20150 or #20209
Closed

[Multi-Domain] Support cy.screenshot #20060

mschile opened this issue Feb 4, 2022 · 2 comments · Fixed by #20119, #20150 or #20209
Assignees
@mschile
Labels
topic: cy.origin Problems or enhancements related to cy.origin command

Comments

@mschile
Copy link
Contributor

mschile commented Feb 4, 2022 •
edited
Loading

What would you like?

  • Add support for cy.screenshot in the secondary domain and unskip this test.
  • Ensure timers are correctly handled.

Why is this needed?

No response

Other

No response
@mschile mschile mentioned this issue Feb 9, 2022
Merged
2 tasks
@chrisbreiding chrisbreiding added topic: cy.origin Problems or enhancements related to cy.origin command and removed stage: work in progress labels Feb 10, 2022
@cypress-bot cypress-bot bot added the stage: needs review The PR code is done & tested, needs review label Feb 10, 2022
@mschile mschile mentioned this issue Feb 11, 2022
Merged
1 task
This was linked to pull requests Feb 11, 2022
feat: (multi-domain) add initial support for cy.screenshot #20119
Merged
feat: (multi-domain) add support for screenshot blackout #20150
Merged
@cypress-bot cypress-bot bot added stage: work in progress and removed stage: needs review The PR code is done & tested, needs review labels Feb 14, 2022
@mschile mschile mentioned this issue Feb 15, 2022
Merged
1 task
@cypress-bot cypress-bot bot added stage: needs review The PR code is done & tested, needs review stage: pending release and removed stage: work in progress stage: needs review The PR code is done & tested, needs review labels Feb 15, 2022
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Feb 17, 2022

The code for this is done in cypress-io/cypress#20209, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@mschile mschile linked a pull request Feb 17, 2022 that will close this issue
feat: (multi-domain) add support for pausing timers during screenshots #20209
Merged
1 task
@mschile mschile closed this as completed Feb 17, 2022
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Apr 25, 2022

Released in 9.6.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v9.6.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Apr 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mschile mschile

Labels
topic: cy.origin Problems or enhancements related to cy.origin command
Projects
None yet
Milestone
No milestone
2 participants
@chrisbreiding @mschile