feat: (multi-domain) add support for screenshot blackout #20150
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User facing changelog
n/a
Additional details
Blacking our screenshot elements in multi-domain was not previously working due to the element logic being executed in the primary domain which resulted in cross-domain failures. In order to resolve the cross-domain issue, the logic is moving to the
screenshot
command which has access to the secondary domain.beforeScreenshot
andafterScreenshot
logic fromaut-iframe.js
toscreenshot.ts
runner
andrunner-ct
add/removeBlackouts
andadd/removeCssAnimationDisabler
functions fromrunner-shared/dom.js
to two new filesanimation.ts
andblackout.ts
in thedriver
.getElementDimensions
function to its own filedimensions.ts
.How has the user experience changed?
Supports blacking out elements in a screenshot:
PR Tasks
cypress-documentation
?type definitions
?cypress.schema.json
?