Upgrade mocha to latest version

[chrisbreiding]

We currently use a forked version of mocha at 2.5.3. Upgrade to the latest version, 5.2.0.

[pvdyck]

@bahmutov ready for Sprint 5 or postpone ?

[jennifer-shehane]

@chrisbreiding Is this going to be a breaking change? 4.0? or?

[chrisbreiding]

Yes, I'd say it's a breaking change.

[chrisbreiding]

The code for this is complete, but has not yet been released. It will be released in 4.0.

[calvinballing]

Note that an additional issue that this will solve is that '.only' currently works based on string matching, so if multiple tests have the same description, they both run if .only is applied to only one. The same occurs if you have multiple tests that share the same starting description. If the first is called 'Admin' and the second is called 'Admin - Page 2', then applying only to the first will cause both to run. Mocha stopped using string matching in v3 https://mochajs.org/

[dwelle]

@calvinballing yep, see #2828

[cypress-bot]

Released in 4.0.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v4.0.0, please open a new issue.