-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add .vscode to git for project specific tasks, debuggers, settings, and terminals #2689
Comments
Won't this conflict if someone already has those files or their own additions? Maybe it should be an example version like |
It's possible, but the VSCode team checks this into source control - and we're not adding anything that's not specific to our actual project there. https://stackoverflow.com/questions/32964920/should-i-commit-the-vscode-folder-to-source-control |
I also do not agree with having this committed to code. Especially since this is open source and many contributors may have their own vscode settings that they could easily accidentally commit or overwrite with ours. I believe we should have some internal documentation regarding our development practices - and add things like VSCode settings there. On top of that, not all of our dev team even uses VSCode. I've especially seen this need with new hires - having to go over general rules |
- fixes cypress-io#1264 - fixes cypress-io#1321 - fixes cypress-io#1799 - fixes cypress-io#2689 - fixes cypress-io#2688 - fixes cypress-io#2687 - fixes cypress-io#2686
Adds:
.vscode/launch.json
for debugging.vscode/settings.json
for project specific settings.vscode/tasks.json
for tasks specific to decaffeinating files, or AST codeshifting.vscode/terminals.json
for plugin specific ways of launching terminals with the correctcwd
for nestedpackages
The text was updated successfully, but these errors were encountered: