Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .vscode to git for project specific tasks, debuggers, settings, and terminals #2689

Closed
brian-mann opened this issue Oct 31, 2018 · 3 comments · Fixed by #2685
Closed
Assignees
Milestone

Comments

@brian-mann
Copy link
Member

Adds:

  • .vscode/launch.json for debugging
  • .vscode/settings.json for project specific settings
  • .vscode/tasks.json for tasks specific to decaffeinating files, or AST codeshifting
  • .vscode/terminals.json for plugin specific ways of launching terminals with the correct cwd for nested packages
@brian-mann brian-mann added this to the Sprint 9 milestone Oct 31, 2018
@brian-mann brian-mann self-assigned this Oct 31, 2018
@chrisbreiding
Copy link
Contributor

Won't this conflict if someone already has those files or their own additions? Maybe it should be an example version like .vscode-example/launch.json, etc so we can take what's in there and merge it into our own non-committed files.

@brian-mann
Copy link
Member Author

It's possible, but the VSCode team checks this into source control - and we're not adding anything that's not specific to our actual project there.

https://stackoverflow.com/questions/32964920/should-i-commit-the-vscode-folder-to-source-control

@jennifer-shehane
Copy link
Member

I also do not agree with having this committed to code. Especially since this is open source and many contributors may have their own vscode settings that they could easily accidentally commit or overwrite with ours.

I believe we should have some internal documentation regarding our development practices - and add things like VSCode settings there. On top of that, not all of our dev team even uses VSCode. I've especially seen this need with new hires - having to go over general rules

brian-mann added a commit that referenced this issue Nov 1, 2018
- fixes #1264 
- fixes #1321 
- fixes #1799  
- fixes #2689
- fixes #2688
- fixes #2687 	
- fixes #2686
kuceb pushed a commit that referenced this issue Nov 14, 2018
- fixes #1264
- fixes #1321
- fixes #1799
- fixes #2689
- fixes #2688
- fixes #2687
- fixes #2686
kuceb pushed a commit to kuceb/cypress that referenced this issue Apr 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants