Cookies are not sent using fetch from electron client #4433

souphan-adsk · 2019-06-11T18:15:36Z

Current behavior:

When the Electron client used by cypress run performs fetch, no cookies are being sent.
This seems to be a behaviour in Cypress' Electron client handling, as I cannot seem to notice it on a raw Electon client.

Desired behavior:

Cookies should be sent. Running against a Chrome browser passes the test.

Steps to reproduce: (app code and test code)

A full minimal project can be found at https://github.com/souphan-adsk/cypress-electron-ajax-cookie

Here are key code sample:

Cypress Spec

describe('Cookie Test', function() {
	it('should send ajax cookie', function() {
		cy.visit('localhost:8880/get-cookie-test');
		cy.wait(500);
		cy.get('#ajax-cookie-value').invoke('text').then((value) => {
			expect(value).to.equal('test=OK')
		});
	});
});

Express

expressApp.get('/get-cookie-test', function(request, response) {
	console.log(request.originalUrl, 'headers.cookie =>', request.headers.cookie);
	response.cookie('test', 'OK', {
		expires: new Date(1000 * 60 * 60 * 24 + Date.now()),
	});
	response.send('<html><body>'
		+ `<p>Cookie value: <span id="cookie-string">${request.headers.cookie}</span></p>`
		+ '<p>Ajax Cookie value: <span id="ajax-cookie-value">...</span></p>'
		+ '<script type="text/javascript">'
		+ '  setTimeout(async () => {'
		+ '    let resp = await fetch("/cookie-echo");'
		+ '    document.getElementById("ajax-cookie-value").innerText = await resp.text();'
		+ '  }, 0);'
		+ '</script>'
		+ '</body></html>'
	);
});

expressApp.get('/cookie-echo', function(request, response) {
	console.log(request.originalUrl, 'headers.cookie =>', request.headers.cookie);
	response.send(request.headers.cookie);
});

Versions

Cypress 3.3.1
Electron 61
OSX

The text was updated successfully, but these errors were encountered:

jsdw · 2019-06-17T15:16:03Z

I have seen the same behaviour using Cypress 3.3.1 and OSX; non-fetch requests send cookies as expected, but fetch based requests do not.

Steakeye · 2019-06-21T14:55:58Z

Experiencing a similar issue working for a client and our tests suddenly stopped failing in headless mode; when debugging the issue it appears as though the cookies we need - which we set earlier before all tests run - are not being passed in the request from the electron client; this is confirmed when using dev tools to look at the network traffic of the headless mode but with --headed flag passed. Everything works fine when using the Cypress UI to access the tests and run them in Chrome.

Steakeye · 2019-06-24T16:29:09Z

Our workaround has been to use the --browser chrome flag; additionally, in CI we now use a different docker image; we switched from using a base image to one that included Chrome (from cypress/base:8 to cypress/browsers:node8.9.3-chrome73).

tgelu · 2019-08-01T10:44:36Z

I experienced the same issue. I figured that the culprit was that the fetch implementation in chrome differs slightly from the one in electron.
According to the fetch specs the credentials property on the Request object you pass to fetch defaults to omit if not specified. That means, among other things, that cookies are not sent with the request unless you specifically say so by passing credentials: "include" or credentials: "same-origin" as described here https://fetch.spec.whatwg.org/#concept-request-credentials-mode
In chrome, though, if you do not specify credentials it seems like it defaults to "same-origin", contrary to WHATWG, which means the cookies will be sent with each fetch request.
I fixed my issue by setting the credentials: "same-origin" on all the requests where I needed that.

Steakeye · 2019-08-01T11:32:27Z

@tgelu

I experienced the same issue. I figured that the culprit was that the fetch implementation in chrome differs slightly from the one in electron.
According to the fetch specs the credentials property on the Request object you pass to fetch defaults to omit if not specified. That means, among other things, that cookies are not sent with the request unless you specifically say so by passing credentials: "include" or credentials: "same-origin" as described here https://fetch.spec.whatwg.org/#concept-request-credentials-mode
In chrome, though, if you do not specify credentials it seems like it defaults to "same-origin", contrary to WHATWG, which means the cookies will be sent with each fetch request.
I fixed my issue by setting the credentials: "same-origin" on all the requests where I needed that.

This is because the spec changed; modern Chrome uses the updated spec while the Electron instance of Chromium that Cypress uses is out of date.

tgelu · 2019-08-01T12:09:08Z

@Steakeye - does this mean this is not an issue with cypress itself but with electron?

Steakeye · 2019-08-01T12:28:53Z

Arguably, as Electron is a dependency of Cypress, it depends on whether or not the latest version of Electron is still using an old version of Chromium, and therefore still has the old `fetch` implementation. If a newer version of Electron exists with the correct implementation, then it would be the responsibility of Cypress to upgrade the version of Electron they are using.

…

On Thu, Aug 1, 2019 at 1:09 PM Gelu Timoficiuc ***@***.***> wrote: @Steakeye <https://github.com/Steakeye> - does this mean this is not an issue with cypress itself but with electron? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#4433?email_source=notifications&email_token=AB6E4WBCYRZKK6JCCWNMWNTQCLG7HA5CNFSM4HXCBKMKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3KLYQA#issuecomment-517258304>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AB6E4WBFD5VK5S2A6SR3B4TQCLG7HANCNFSM4HXCBKMA> .

bahmutov · 2019-08-01T13:31:54Z

yes, and we are trying to upgrade Electron to the latest v6 in this pull request #4720

cypress-bot · 2019-09-24T18:35:44Z

The code for this is done in cypress-io/cypress#4720, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

cypress-bot · 2019-09-24T18:35:50Z

The code for this is done in cypress-io/cypress#4720, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

cypress-bot · 2019-10-23T21:50:43Z

Released in 3.5.0.

jennifer-shehane added the topic: cookies 🍪 label Jun 17, 2019

cypress-bot bot added the stage: needs investigating Someone from Cypress needs to look at this label Jun 17, 2019

This was referenced Aug 2, 2019

Upgrade to the latest version of Electron #3568

Closed

Electron v5.0.10 #4720

Merged

cypress-bot bot added stage: work in progress and removed stage: needs investigating Someone from Cypress needs to look at this labels Aug 13, 2019

cypress-bot bot added stage: needs review The PR code is done & tested, needs review and removed stage: work in progress labels Sep 12, 2019

brian-mann closed this as completed in #4720 Sep 24, 2019

cypress-bot bot added stage: pending release and removed stage: needs review The PR code is done & tested, needs review labels Sep 24, 2019

cypress-bot bot removed the stage: pending release label Oct 23, 2019

snyk-bot mentioned this issue Nov 1, 2019

[Snyk] Upgrade cypress from 3.4.1 to 3.5.0 ngChile/ngx-devkit-cypress-builder#14

Merged

snyk-bot mentioned this issue Nov 9, 2019

[Snyk] Upgrade cypress from 3.5.0 to 3.6.0 ngChile/ngx-devkit-cypress-builder#19

Closed

cypress-io locked as resolved and limited conversation to collaborators Jan 3, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Cookies are not sent using fetch from electron client #4433

Cookies are not sent using fetch from electron client #4433

souphan-adsk commented Jun 11, 2019

jsdw commented Jun 17, 2019

Steakeye commented Jun 21, 2019

Steakeye commented Jun 24, 2019 •

edited

Loading

tgelu commented Aug 1, 2019 •

edited

Loading

Steakeye commented Aug 1, 2019 •

edited

Loading

tgelu commented Aug 1, 2019

Steakeye commented Aug 1, 2019 via email

bahmutov commented Aug 1, 2019

cypress-bot bot commented Sep 24, 2019

cypress-bot bot commented Sep 24, 2019

cypress-bot bot commented Oct 23, 2019

Cookies are not sent using fetch from electron client #4433

Cookies are not sent using fetch from electron client #4433

Comments

souphan-adsk commented Jun 11, 2019

Current behavior:

Desired behavior:

Steps to reproduce: (app code and test code)

Cypress Spec

Express

Versions

jsdw commented Jun 17, 2019

Steakeye commented Jun 21, 2019

Steakeye commented Jun 24, 2019 • edited Loading

tgelu commented Aug 1, 2019 • edited Loading

Steakeye commented Aug 1, 2019 • edited Loading

tgelu commented Aug 1, 2019

Steakeye commented Aug 1, 2019 via email

bahmutov commented Aug 1, 2019

cypress-bot bot commented Sep 24, 2019

cypress-bot bot commented Sep 24, 2019

cypress-bot bot commented Oct 23, 2019

Steakeye commented Jun 24, 2019 •

edited

Loading

tgelu commented Aug 1, 2019 •

edited

Loading

Steakeye commented Aug 1, 2019 •

edited

Loading