Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct reason not visible when element is detached from DOM #4946

Closed
kuceb opened this issue Aug 7, 2019 · 2 comments · Fixed by #4945
Closed

Correct reason not visible when element is detached from DOM #4946

kuceb opened this issue Aug 7, 2019 · 2 comments · Fixed by #4945

Comments

@kuceb
Copy link
Contributor

kuceb commented Aug 7, 2019

Currently, if an element gets detached/removed from the DOM during actionability, you get:

'This element '...' is not visible because it has an effective width and height of: '0 x 0' pixels'

This happens when element is removed or re-rendered on scroll, for example.

We should provide a more precise error message so that this issue can be better resolved: #695
@kuceb kuceb mentioned this issue Aug 7, 2019
Merged
5 tasks
@cypress-bot cypress-bot bot added the stage: needs review The PR code is done & tested, needs review label Aug 7, 2019
@kuceb kuceb mentioned this issue Aug 12, 2019
Closed
@cypress-bot cypress-bot bot added stage: work in progress stage: needs review The PR code is done & tested, needs review and removed stage: needs review The PR code is done & tested, needs review stage: work in progress labels Sep 25, 2019
@cypress-bot cypress-bot bot added stage: pending release and removed stage: needs review The PR code is done & tested, needs review labels Sep 29, 2019
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Sep 29, 2019

The code for this is done in cypress-io/cypress#4945, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Oct 23, 2019

Released in 3.5.0.

@snyk-bot snyk-bot mentioned this issue Nov 1, 2019
Merged
@snyk-bot snyk-bot mentioned this issue Nov 9, 2019
Closed
@jennifer-shehane jennifer-shehane mentioned this issue May 12, 2020
Closed
@cypress-io cypress-io locked as resolved and limited conversation to collaborators Dec 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(errors): better error message when element is detached during actionability cypress-io/cypress
1 participant
@kuceb