Types for Cypress.Commands.overwrite are incorrect - does not take command options

[CSchulz]

Current behavior:

    Commands: {
      add(name: string, fn: (...args: any[]) => void): void
      add(name: string, options: CommandOptions, fn: (...args: any[]) => void): void
      overwrite(name: string, fn: (...args: any[]) => void): void
      overwrite(name: string, options: CommandOptions, fn: (...args: any[]) => void): void
    }

Desired behavior:

    Commands: {
      add(name: string, fn: (...args: any[]) => void): void
      add(name: string, options: CommandOptions, fn: (...args: any[]) => void): void
      overwrite(name: string, fn: (...args: any[]) => void): void
    }

Steps to reproduce: (app code and test code)

cypress/packages/driver/src/cypress/commands.coffee

Lines 151 to 152 in a038e7f

	overwrite: (name, fn) ->
	storeOverride(name, fn)

Versions

3.4.1

[jennifer-shehane]

@CSchulz Yeah, this seems to be completely true, which means the docs are incorrect as well. https://on.cypress.io/custom-commands#Syntax

I created a new issue in our docs to document the options not being available during overwrite here: cypress-io/cypress-documentation#2147.

[jennifer-shehane]

I've opened a PR to fix the typings here: #5347

[cypress-bot]

The code for this is done in cypress-io/cypress#5347, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

[cypress-bot]

Released in 3.5.0.