Typing a modifier key anywhere removes selected text from an input in 3.5.0

[dwelle]

Current behavior:

Typing a modifier key into an input anywhere removes selected text in an active input.

Desired behavior:

Shouldn't touch input value at all.

Steps to reproduce: (app code and test code)

describe('test', () => {
    it('test', () => {
        cy.document().then(doc => {
            doc.body.innerHTML = `
                <textarea class="one">hello</textarea>
                <textarea class="two">hello</textarea>
                <input class="three" value="hello">
            `;
        });

        // (1) clears whole textarea
        cy.get('.one').type('{selectall}').type('{ctrl}');

        // (2) clears whole textarea
        cy.get('.two').type('{selectall}');
        cy.get('body').type('{ctrl}');

        // (3) removes last letter
        cy.get('.three')
            .focus()
            .then( $input => {
                $input[0].selectionStart = 4;
                $input[0].selectionEnd = 5;
            })
            .type('{ctrl}');
    });
});

Versions

• Cypress 3.5.0, Win 7, chrome stable 77 (headed) & chrome canary 73 (headless)
• It's possible a regression in older cypress version (I've migrated from 3.3.1 → 3.5.0 directly)

[jennifer-shehane]

I can confirm that this behavior has changed from 3.4.1 to 3.5.0.

Test exhibiting change.

describe('test', () => {
  it('test', () => {
    cy.document().then((doc) => {
      doc.body.innerHTML = `
        <textarea class="one">hello</textarea>
        <textarea class="two">hello</textarea>
        <input class="three" value="hello">
      `
    })

    // (1) clears whole textarea
    cy.get('.one').type('{selectall}').type('{ctrl}')

    // (2) clears whole textarea
    cy.get('.two').type('{selectall}')
    cy.get('body').type('{ctrl}')

    // (3) removes last letter
    cy.get('.three')
      .focus()
      .then(($input) => {
        $input[0].selectionStart = 4
        $input[0].selectionEnd = 5
      })
      .type('{ctrl}')
      .should('have.value', 'hello')
  })
})

3.4.1

3.5.0

This does appear to me to be a bug - since doing this behavior manually does not clear the selected value when pressing {ctrl} on the keyboard. This may be related to this change: #5424 @bkucera will have a lot more insight into this however.

[cypress-bot]

The code for this is done in cypress-io/cypress#5496, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

[cypress-bot]

The code for this is done in cypress-io/cypress#5496, but has yet to be released.
We'll update this issue and reference the changelog when it's released.