Display accurate error message when browser is not supported

[mydiemho]

Current behavior:

Safari is currently not supported. However, the error message is misleading user to think that Safari is not installed vs it not being supported.

> npx cypress run --browser  "safari"

Can't run because you've entered an invalid browser name.

Browser: 'safari' was not found on your system.

Available browsers found are: chrome, firefox, electron

Desired behavior:

Accurate error message. For example:

> npx cypress run --browser  "safari"

Can't run because you've entered an invalid browser name.

Browser: 'safari' is not supported

Supported browsers are: chrome, firefox, electron, edge

Test code to reproduce

Run the following on a host with Safari installed.

 npx cypress run --browser  "safari"

Versions

1. Cypress

➜ npx cypress -v
Cypress package version: 4.3.0
Cypress binary version: 4.3.0

1. Operating System
   macOS 10.15.4

2. Browser
   Safari

Related #6422

[jennifer-shehane]

Yah, this may not be as straightforward because you can actually customize the available browsers. https://on.cypress.io/launching-browsers#Customize-available-browsers

But yes, I agree this could be a better error message.

Supported browser is actually a bit longer also:

Canary
Chrome
Chromium
Edge
Edge Beta
Edge Canary
Edge Dev
Electron
Firefox (Beta support)
Firefox Developer Edition (Beta support)
Firefox Nightly (Beta support)

[flozender]

Hi, I'd like to work on this! I do need a little help getting started. What directories would I have to go through in order to make the changes? Thank you!

[flozender]

One way to do it would be to add a conditional statement in packages/server/lib/errors.coffee, in the when "BROWSER_NOT_FOUND_BY_NAME" switch case, and modify the error string accordingly for when safari is an argument. Please let me know if I am on the right track.

[cypress-bot]

The code for this is done in cypress-io/cypress#7375, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

[cypress-bot]

Released in 4.8.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v4.8.0, please open a new issue.