-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update browser not supported message #7375
Conversation
Thanks for the contribution! Below are some guidelines Cypress uses when doing PR reviews.
PR Review ChecklistIf any of the following requirements can't be met, leave a comment in the review selecting 'Request changes', otherwise 'Approve'. User Experience
Functionality
Maintainability
Quality
Internal
|
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice! this should help make things clearer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pending release of https://github.com/cypress-io/cypress-services/pull/2601 where this link should work: https://on.cypress.io/customize-browsers
User facing changelog
Updates the error message when a browser is not found or not supported
Additional details
The current message isn't very clear when it comes to unsupported browsers. For example, it can be confusing to see that Cypress cannot find Safari when in reality Safari is just not supported.
How has the user experience changed?
Previous error message
cypress run
:New error message
cypress run
:Previous error message
cypress open
:New error message
cypress open
:PR Tasks