change event not firing on email input in React 16

[chodorowicz]

• Operating System: MacOS
• Cypress Version: 1.0.2
• Browser Version: Electron / Chrome 61

Is this a Feature or Bug?

Bug

Current behavior:

When running test via headless Electron change event is not fired for email type input. For text input it works correctly. Also text and input work correctly in standard Chrome.

Desired behavior:

Cypress should fire change event.

How to reproduce:

Run test cypress run on following app: https://stackblitz.com/edit/react-eadssh?file=index.js (need to export it and run locally, embedding doesn't seem to work)

import React, { Component } from 'react';
import { render } from 'react-dom';

class App extends Component {
  state = {
    inputValue: '',
    message: ''
  };

  handleChange = (event) => {
    this.setState({ 
      inputValue: event.currentTarget.value,
    });
  }

  handleSubmit = (event) => {
    event.preventDefault();
    this.setState({
      message: this.state.inputValue === ''
        ? 'Error'
        : 'All good'
    });
  }

  render() {
    return (
      <div>
        input value: {this.state.inputValue}
        <form onSubmit={this.handleSubmit}>
          <input onChange={this.handleChange} value={this.state.inputValue} id="input" type="email" />
          <button>submit</button>
        </form>
        {this.state.message}
      </div>
    );
  }
}

render(<App />, document.getElementById('root'));

Test code:

describe('app', () => {
  it('should work with input email type', () => {
    cy.visit('http://localhost:3000/');
    cy.get('#input').type('user@example.com');
    cy.contains('submit').click();
    cy.contains('All good');
  });
});

Additional Info (images, stack traces, etc)

related tickets:

• More comprehensive fix is needed for React 16 to fire change events #647
• react input type email clears, not firing event #770
• test written only for standard input type 4a56ca8

failing with input type email

all good with text input type

[ghost]

Downgrading to 1.0.1 solved the issue for me.

[chodorowicz]

For me with 1.0.1 it doesn't work at all, even in GUI Chrome 61. 1.0.2 was supposed to fix issues with type not firing change events, so it makes sense it doesn't work for me at all.

[brian-mann]

I'll take a look at this / fix it and we'll release 1.0.3.

We added a bunch of react tests in 1.0.2 (you all can look at the code) and we run our driver tests in both Electron and Chrome, so I'm curious how this could have gotten missed.

Appreciate you all creating a reproducible example.

The new tests for react 16 are here: https://github.com/cypress-io/cypress/blob/develop/packages/driver/test/cypress/integration/e2e/react-16_spec.coffee

This uses an html fixture here: https://github.com/cypress-io/cypress/blob/develop/packages/driver/test/cypress/fixtures/react-16.html

[jennifer-shehane]

We are also experiencing this issue within our own Dashboard Service project which uses React 15 on Cypress version 1.0.2.

Failing, reproducible spec here: https://github.com/cypress-io/cypress-dashboard/blob/develop/cypress/integration/users_spec.coffee#L266

[chodorowicz]

@brian-mann Thanks for the answer! What would be a good reproducible example? I've pasted code and test samples? Should I fork the repo and add failing test case?

[Fjoggs]

I left a comment on this issue on the already closed issue that supposedly solved it, but didn't receive a response. I'm not too familiar with github issues, so I guess I should have just opened a new one? :)

Anyway, I have the same problem, using React 16 and Cypress 1.0.2.
Event's aren't firing for input type="number" using Electron.

[brian-mann]

Fixed in 1.0.3.

[chodorowicz]

Great, thank you 🙇