Issue 442 - blacklisting hosts with config.json #1062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bahmutov
reviewed
Dec 13, 2017
| @@ -103,6 +104,7 @@ defaults = { | |||
| validationRules = { | |||
| animationDistanceThreshold: v.isNumber | |||
| baseUrl: v.isFullyQualifiedUrl | |||
| blacklistHosts: v.isStringOrArrayOfStrings | |||
There was a problem hiding this comment.
string or array of strings here
bahmutov
reviewed
Dec 13, 2017
| ## else return the host | ||
| return host | ||
|
|
||
| matches = (urlToCheck, blacklistHosts) -> |
There was a problem hiding this comment.
I would check blackListHosts type here - if type is not string or array of strings, something went wrong. Throw
There was a problem hiding this comment.
also, what does this return? needs a jsdoc block I feel, because this is so reusable
bahmutov
reviewed
Dec 13, 2017
| expectedHeader = (res, val) -> | ||
| expect(res.headers["x-cypress-matched-blacklisted-host"]).to.eq(val) | ||
|
|
||
| Promise.all([ |
There was a problem hiding this comment.
you can also use https://github.com/bahmutov/snap-shot-it#data-driven-testing to make the test simpler here
bahmutov
reviewed
Dec 13, 2017
|
|
||
| matchesStr = (url, host, val) -> | ||
| m = blacklist.matches(url, host) | ||
| expect(!!m).to.eq(val, "url: '#{url}' did not pass") |
… localhost was causing ws connection issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #442