fix(typedefs): Add type for autoEnd on LogConfig. #14220
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User facing changelog
Add type for autoEnd on LogConfig.
Additional details
I wanted to make a small contribution to Cypress and get the dev environment set up. The only change I made was adding the type.
Side notes about Cypress development:
After I made the change, I built the package and built the binary, and in my test project I pointed to the package in package.json and had to copy paste the binary into my cypress cache in order to successfully
yarn
on my test project, otherwise it would try to download the binary online and fail since the version didn't exist.I also had to downgrade my node version to avoid a build error in node-sass.
How has the user experience changed?
Now it doesn't produce a type error and shows autoEnd correctly typed.
PR Tasks
type definitions
?