Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add before:run event #14238

Merged
merged 42 commits into from
Dec 21, 2020
Merged

feat: Add before:run event #14238

merged 42 commits into from
Dec 21, 2020

Conversation

chrisbreiding
Copy link
Contributor

@chrisbreiding chrisbreiding commented Dec 18, 2020

NOTE: Merge #9595 first and change base branch before merging this

User facing changelog

  • You can now listen to a before:run event in the plugins file. See the documentation for more information (TODO: link to doc).

Additional details

  • The event fires before the run.
  • It only fires in run mode.
  • If running parallel, it will run for each machine running.
  • The event handler receives one argument, an object with details about the run.
on('before:run', (details) => {
  // details:
  // {
  //   browser: {
  //     name: 'electron',
  //     family: 'chromium',
  //     version: '87.0.4280.67',
  //     // ... more properties
  //   },
  //   config: {
  //     projectName: 'my-app',
  //     baseUrl: 'http://localhost:1234',
  //     // ... more properties
  //   },
  //   cypressVersion: '6.1.0',
  //   group: 'group-1',
  //   parallel: false,
  //   specs: [
  //     {
  //       name: 'login_spec.js',
  //       relative: 'cypress/integration/login_spec.js',
  //       absolute: '/Users/janelane/my-app/cypress/integration/login_spec.js',
  //       specType: 'integration'
  //     }
  //   ],
  //   specPattern: [ 'cypress/integration/login_spec.js' ],
  //   system: { osName: 'darwin', osVersion: '19.6.0' },
  //   tag: 'tag-1'
  // }

})

PR Tasks

chrisbreiding and others added 30 commits December 9, 2020 13:48
mostly for the run_spec.js test's sake, so they don't fail because they don't pass config in
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Dec 18, 2020

Thanks for taking the time to open a PR!

@chrisbreiding chrisbreiding changed the base branch from develop to TR-536-handled-deleted-videos December 18, 2020 16:00
@cypress
Copy link

cypress bot commented Dec 18, 2020



Test summary

9162 0 118 3Flakiness 1


Run details

Project cypress
Status Passed
Commit 39e798e
Started Dec 21, 2020 5:30 PM
Ended Dec 21, 2020 5:43 PM
Duration 12:38 💡
OS Linux Debian - 10.5
Browser Multiple

View run in Cypress Dashboard ➡️


Flakiness

cypress/integration/retries.ui.spec.js Flakiness
1 runner/cypress retries.ui.spec > opens attempt on each attempt failure for the screenshot, and closes after test passes

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

flotwig
flotwig previously approved these changes Dec 18, 2020
@chrisbreiding chrisbreiding mentioned this pull request Dec 21, 2020
4 tasks
@chrisbreiding chrisbreiding changed the base branch from TR-536-handled-deleted-videos to develop December 21, 2020 17:17
@chrisbreiding chrisbreiding dismissed flotwig’s stale review December 21, 2020 17:17

The base branch was changed.

@chrisbreiding chrisbreiding merged commit d6c0bcf into develop Dec 21, 2020
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Dec 21, 2020

Released in 6.2.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v6.2.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Dec 21, 2020
@chrisbreiding chrisbreiding deleted the TR-538-before-run-event branch April 5, 2022 18:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants