Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: exception when recording with no tests in specfile #15517

Merged
merged 6 commits into from
Mar 17, 2021

Conversation

kuceb
Copy link
Contributor

@kuceb kuceb commented Mar 16, 2021

User facing changelog

Additional details

How has the user experience changed?

PR Tasks

  • Have tests been added/updated?
  • Has the original issue or this PR been tagged with a release in ZenHub?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Mar 16, 2021

Thanks for taking the time to open a PR!

@jennifer-shehane
Copy link
Member

Keep getting this error when trying to record in staging.

Recording this run failed because the request was invalid.

Request should follow postRunRequest@2.2.0 schema

Errors:

[
  "data has additional properties: runnerCapabilities"
]

Request Sent:

{
  "ci": {
    "params": null,
    "provider": null
  },
  "specs": [
    "cypress/integration/spec.js",
    "cypress/integration/untitled_spec.js",
    "cypress/integration/untitled_spec2.js",
    "cypress/integration/untitled_spec3.js"
  ],
  "commit": {
    "sha": "71b5c34e5b4bb24fd00a9e43a4222c31161299c1",
    "branch": "master",
    "authorName": "Ralf Richtsteiger",
    "authorEmail": "dev@rwam.de",
    "message": "add example code\n",
    "remoteOrigin": "https://github.com/rwam/cypress-test.git",
    "defaultBranch": null
  },
  "group": null,
  "platform": {
    "osCpus": [
      {
        "model": "Intel(R) Core(TM) i7-8850H CPU @ 2.60GHz",
        "speed": 2600,
        "times": {
          "user": 48215720,
          "nice": 0,
          "sys": 31910740,
          "idle": 144684890,
          "irq": 0
        }
      },
      {
        "model": "Intel(R) Core(TM) i7-8850H CPU @ 2.60GHz",
        "speed": 2600,
        "times": {
          "user": 3793580,
          "nice": 0,
          "sys": 5562250,
          "idle": 215287340,
          "irq": 0
        }
      },
      {
        "model": "Intel(R) Core(TM) i7-8850H CPU @ 2.60GHz",
        "speed": 2600,
        "times": {
          "user": 41126270,
          "nice": 0,
          "sys": 23321200,
          "idle": 160199290,
          "irq": 0
        }
      },
      {
        "model": "Intel(R) Core(TM) i7-8850H CPU @ 2.60GHz",
        "speed": 2600,
        "times": {
          "user": 3782870,
          "nice": 0,
          "sys": 5308350,
          "idle": 215551590,
          "irq": 0
        }
      },
      {
        "model": "Intel(R) Core(TM) i7-8850H CPU @ 2.60GHz",
        "speed": 2600,
        "times": {
          "user": 34483520,
          "nice": 0,
          "sys": 19475270,
          "idle": 170687320,
          "irq": 0
        }
      },
      {
        "model": "Intel(R) Core(TM) i7-8850H CPU @ 2.60GHz",
        "speed": 2600,
        "times": {
          "user": 3794280,
          "nice": 0,
          "sys": 5127750,
          "idle": 215720400,
          "irq": 0
        }
      },
      {
        "model": "Intel(R) Core(TM) i7-8850H CPU @ 2.60GHz",
        "speed": 2600,
        "times": {
          "user": 28699140,
          "nice": 0,
          "sys": 16052610,
          "idle": 179893690,
          "irq": 0
        }
      },
      {
        "model": "Intel(R) Core(TM) i7-8850H CPU @ 2.60GHz",
        "speed": 2600,
        "times": {
          "user": 3790350,
          "nice": 0,
          "sys": 4994960,
          "idle": 215856750,
          "irq": 0
        }
      },
      {
        "model": "Intel(R) Core(TM) i7-8850H CPU @ 2.60GHz",
        "speed": 2600,
        "times": {
          "user": 25706030,
          "nice": 0,
          "sys": 14136700,
          "idle": 184802050,
          "irq": 0
        }
      },
      {
        "model": "Intel(R) Core(TM) i7-8850H CPU @ 2.60GHz",
        "speed": 2600,
        "times": {
          "user": 3758100,
          "nice": 0,
          "sys": 4879550,
          "idle": 216004010,
          "irq": 0
        }
      },
      {
        "model": "Intel(R) Core(TM) i7-8850H CPU @ 2.60GHz",
        "speed": 2600,
        "times": {
          "user": 21328750,
          "nice": 0,
          "sys": 11575640,
          "idle": 191739730,
          "irq": 0
        }
      },
      {
        "model": "Intel(R) Core(TM) i7-8850H CPU @ 2.60GHz",
        "speed": 2600,
        "times": {
          "user": 3746870,
          "nice": 0,
          "sys": 4782160,
          "idle": 216112250,
          "irq": 0
        }
      }
    ],
    "osName": "darwin",
    "osMemory": {
      "free": 842321920,
      "total": 17179869184
    },
    "osVersion": "19.6.0",
    "browserName": "Electron",
    "browserVersion": "87.0.4280.141"
  },
  "parallel": null,
  "ciBuildId": null,
  "projectId": "6wa698",
  "recordKey": "5df12e37-11cc-4f1d-a0a0-a7e6842aef6e",
  "specPattern": null,
  "tags": [
    ""
  ],
  "runnerCapabilities": {
    "dynamicSpecsInSerialMode": true,
    "skipSpecAction": true
  }
}

Copy link
Member

@jennifer-shehane jennifer-shehane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manually tested - this fixes the issue. Also tested.

Copy link
Member

@jennifer-shehane jennifer-shehane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This exits and does report a Dashboard url, but it looks like it reports as pending forever. So, not sure if this is relevant. https://dashboard-staging.cypress.io/projects/o9ej5p/runs/1

@cypress
Copy link

cypress bot commented Mar 16, 2021



Test summary

9392 0 119 3Flakiness 1


Run details

Project cypress
Status Passed
Commit b85f6e3
Started Mar 17, 2021 3:02 PM
Ended Mar 17, 2021 3:13 PM
Duration 10:42 💡
OS Linux Debian - 10.5
Browser Multiple

View run in Cypress Dashboard ➡️


Flakiness

cypress/integration/retries.ui.spec.js Flakiness
1 runner/cypress retries.ui.spec > opens attempt on each attempt failure for the screenshot, and closes after test passes

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@brian-mann
Copy link
Member

This sounds pretty relevant to me... @bkucera and @traviscy thoughts?

brian-mann
brian-mann previously approved these changes Mar 17, 2021
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Mar 17, 2021

Released in 6.8.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v6.8.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Mar 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when running test suite with empty spec files
3 participants