Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(component-testing): Search spec overflowing #15534

Merged
merged 2 commits into from
Mar 17, 2021

Conversation

dmtrKovalenko
Copy link
Contributor

When we have a lot of specs:

Before:

Screenshot 2021-03-17 at 12 24 56

After:

Screenshot 2021-03-17 at 12 27 59

@dmtrKovalenko dmtrKovalenko requested a review from a team March 17, 2021 10:31
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Mar 17, 2021

Thanks for taking the time to open a PR!

@cypress
Copy link

cypress bot commented Mar 17, 2021



Test summary

3984 0 49 2Flakiness 0


Run details

Project cypress
Status Passed
Commit e8599d6
Started Mar 17, 2021 3:20 PM
Ended Mar 17, 2021 3:29 PM
Duration 09:45 💡
OS Linux Debian - 10.5
Browser Chrome 83

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@@ -7,7 +7,9 @@
width: 100%;
padding: 8px;
box-sizing: border-box;

background-color: white;
z-index: 10;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless you have a z-index of 9, this is an incorrect assignment. z-index is entirely based on stacking context, so if you're an old-school JS dev, setting z-index: 1000 or whatever didn't actually do anything special.

Most likely (without pulling down the branch and trying it myself) you want z-index: 1

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. You can pull the branch and debug it yourself. I prefer tailwind style of indexing with a 10x. Previous is 1 new is 10 next is 100

@dmtrKovalenko dmtrKovalenko merged commit 8c9cf19 into develop Mar 17, 2021
@dmtrKovalenko dmtrKovalenko deleted the fix/ct-search-spec-overflow branch March 17, 2021 15:37
This was referenced Mar 18, 2021
This was referenced Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants