feat: updated scaffolding, new project & user banners, ability to remove scaffolding #15826
Conversation
|
Thanks for taking the time to open a PR!
|
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
panzarino
changed the title
panzarino
changed the title
panzarino
changed the title
There was a problem hiding this comment.
@panzarino So, this seems to have really broken the initial scaffolding of files on Windows.
I attached a photo of what is scaffolded. This seems really weird. Where is this eha directory even coming from??
We've had reports of like, weird scaffolding before on Windows (I'd have to find them). So I thought maybe I did something unusual. But I made sure to switch to develop to confirm that it doesn't happen on develop.
I would suggest setting up a VM at this point - if only to have 2 people verify the behavior and isolate whether it's a local issue or not. It will also close the loop on work + review so this can get done quicker. Sorry. :(
|
@jennifer-shehane Yeah I had a feeling that the initial scaffolding would break with some of the changes that I just introduced - I've reverted those and kept some of the removal changes so hopefully everything works properly now. I'm working on setting up a VM so that I can test on my own - thanks for being so patient and testing this on Windows so many times already. |
There was a problem hiding this comment.
@panzarino The scaffolding is fixed now, but after confirming to delete the files - the files are not deleting on Windows.
|
@jennifer-shehane Thought that might happen - I have slow internet so I'm unable to download Windows for a VM in a realistic timeframe. I'm currently testing through appveyor and looking at the test results there to hopefully get it to work - once the unit tests pass on windows I imagine it would work properly in practice |
|
@panzarino K, let me know when you want me to run again. Setting up a VM will take a long time. |
|
@jennifer-shehane So I believe that I've finally actually fixed the problem - I've gotten all remove scaffolding unit tests to pass on appveyor so I'm confident that it'll actually work in manual testing. |
There was a problem hiding this comment.
@panzarino Seems to be working now on Windows + Mac. Looks like it will make it in this release. 👍
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Adds some of the functionality (or equivalent) mentioned in #3364, given this work + CT CLI might be time to close that issue?
Updated scaffolding changes implemented in cypress-io/cypress-example-kitchensink#481
User facing changelog
List of things in this PR that could be mentioned in changelog:
Not sure if we need to include specifics around the modal/banners - we could probably just consolidate to improved first time / new project onboarding experience
Additional details
For removing files, we only remove files that came from our scaffolding and were not modified (compares by name, filesize) to ensure that users do not loose any of their work.
The new user banner will only appear the first time that someone uses Cypress if they're joining an existing project. The new project banner will appear on every new project.
Updated kitchen sink has been deployed
How has the user experience changed?
Here's a gif showing the new project banner as well as deleting the example files and the updated "no files found" screen
Here's what the new user banner looks like (joining an existing project)
PR Tasks
cypress-documentation?type definitions?cypress.schema.json?