-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cypress/react): add default webpack config path #16813
Conversation
Thanks for taking the time to open a PR!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I would say that's a woops
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
…ypress-io/cypress into fix/cypress-react-webpack-path
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With an example test? Even better !
User facing changelog
#16751 added a config object to modify the webpack config path. We need a default for users who are not providing the configuration object.
Additional details
This is very awkward to test. We'd need another entire project - should look into this, but this fix is pretty important to get out, so I just tested it by creating a project, reproducing the error, then updating
node_modules
.How has the user experience changed?
PR Tasks
cypress-documentation
?type definitions
?cypress.schema.json
?