Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Inject into hard-coded secondary domain #16873

Merged

Conversation

chrisbreiding
Copy link
Contributor

Uses the proxy to inject code necessary for Cypress to run into a secondary domain. Currently, it's hard-coded to 127.0.0.1:3501, but that restriction will be removed in the future once other aspects of multidomain are implemented.

This is still an improvement, as before the page being visited had to have the injection code already hard-coded into it, now it's possible to visit any page on 127.0.0.1:3501 and the injection code will be dynamically added.

@chrisbreiding chrisbreiding requested a review from a team as a code owner June 9, 2021 14:02
@chrisbreiding chrisbreiding requested review from flotwig and removed request for a team June 9, 2021 14:02
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jun 9, 2021

Thanks for taking the time to open a PR!

@chrisbreiding chrisbreiding requested a review from kuceb June 9, 2021 14:02
@cypress
Copy link

cypress bot commented Jun 9, 2021



Test summary

17957 2 217 7Flakiness 3


Run details

Project cypress
Status Errored
Commit af647ac
Started Jun 14, 2021 7:13 PM
Ended Jun 14, 2021 7:24 PM
Duration 10:57 💡
OS Linux Debian - 10.8
Browser Multiple

View run in Cypress Dashboard ➡️


Failures

cypress/integration/commands/net_stubbing_spec.ts Failed
1 network stubbing > waiting and aliasing > can timeout waiting on a single request using "alias.request"

Flakiness

reporter.errors.spec.js Flakiness
1 errors ui > docs url > displays as button in interactive mode
retries.ui.spec.js Flakiness
1 runner/cypress retries.ui.spec > opens attempt on each attempt failure for the screenshot, and closes after test passes
2 runner/cypress retries.ui.spec > opens attempt on each attempt failure for the screenshot, and closes after test passes

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

Copy link
Contributor

@flotwig flotwig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chrisbreiding chrisbreiding merged commit b8658cf into feature-multidomain Jun 15, 2021
@chrisbreiding chrisbreiding deleted the issue-16450-multidomain-inject-cypress branch April 5, 2022 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants