cy.screenshot bug fixes and enhancements #1793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…een rendering incorrectly upscaling screenshots - when electron is running in offscreen headless mode with a retina screen it incorrectly sets devicePixelRatio to one, but still takes a screenshot at 2x ratio, which then upscales the pixels and blurs the pixels, which defeats the pixel checking. - this fix forces electron to render only at a device pixel ratio of 1 when headless. it works normally when headed without having to do anything special - this fixes a bug where pixel coordinate checking was hard coded and was not factoring in device ratio
brian-mann
changed the title
sebinsua
reviewed
Aug 15, 2019
| # to force retina screens to not | ||
| # upsample their images when offscreen | ||
| # rendering | ||
| require("./util/electron_app").scale() |
There was a problem hiding this comment.
@brian-mann Hey, I had an issue in which I couldn't use the image regression plugin cypress-image-snapshot because the snapshots created were different between headed mode and headless mode.
I worked out that this was because BrowserWindow#capturePage resolves to an image of a different size dependent on the scale factor, and by default cypress open was giving me a scale factor which was different from the one set in headless mode.
How would you feel about there being a configuration option to set a scale factor across all browsers? Currently, this hardcodes it as 1, and there isn't a way of setting it for a headed electron environment.
This was referenced Apr 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1792