-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow use of javascript in config file #18061
Conversation
Thanks for taking the time to open a PR!
|
This reverts commit ff3baa1.
Test summaryRun details
View run in Cypress Dashboard ➡️ Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
Updating from develop since we fixed the intercept flaky tests. Hopefully this should help determine flake from failures. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. I thoroughly tested the e2e runner.
This looks good @jennifer-shehane. Ready to go as soon as you give your 👍. |
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Closes https://cypress-io.atlassian.net/browse/UNIFY-346
Preamble
As discussed with @jennifer-shehane on Sep 9th 2021, this PR is the first of a series of PRs to get to the
cypress.config.ts
new syntax. This is a follow-up to #17000.Here is the list of discreet changes that will be merged as gradually as possible into develop:
First, these will not change end-user experience
cypress.config.js
with the exact same data schema as a custom config filecypress.config.js
as a default config filecypress.config.ts
defineConfig()
function to facilitate configuration in a JavaScript filesetupNodeEvents()
config to configure plugins in thecypress.config.js
filecypress.config.js
component.devServer()
+component.devServerOptions
to streamline configuration of component testing.Then changing the defaults and adding warning
cypress.json
andplugins/index.js
to usingcypress.config.js
User facing changelog
cypress.json
file. Use the option--config-file my.config.for.cypress.js
to specify where your file is.Additional details
cypress.config.js
properlyTo test
Create a project with a js file as the config file
yarn create vite test-project cd text-project yarn create cypress-tests mv cypress.json cypress.config.custom.js
Then open
cypress.config.custom.js
and writemodule.exports = { viewportWidth:300 }
in it.PR Tasks