Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update DRONE branch used for Dashboard #18062

Merged
merged 1 commit into from
Sep 15, 2021
Merged

Conversation

jennifer-shehane
Copy link
Member

@jennifer-shehane jennifer-shehane commented Sep 10, 2021

User Facing Changelog

  • Update the branch collected for drone CI to reflect the source PR branch.

Additional Details

We previously used the DRONE_COMMIT_BRANCH which is actually the target branch the PR is being merged into. What we want is the DRONE_SOURCE_BRANCH which is the actual branch of the PR.

@jennifer-shehane jennifer-shehane requested a review from a team as a code owner September 10, 2021 18:41
@jennifer-shehane jennifer-shehane requested review from flotwig and chrisbreiding and removed request for a team September 10, 2021 18:41
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Sep 10, 2021

Thanks for taking the time to open a PR!

@cypress
Copy link

cypress bot commented Sep 10, 2021



Test summary

4184 2 53 1Flakiness 3


Run details

Project cypress
Status Failed
Commit 078e6bd
Started Sep 14, 2021 3:04 PM
Ended Sep 14, 2021 3:16 PM
Duration 12:19 💡
OS Linux Debian - 10.9
Browser Firefox 89

View run in Cypress Dashboard ➡️


Failures

commands/actions/type_spec.js Failed
1 ... > element
e2e/focus_blur_spec.js Failed
1 intercept blur methods correctly > focus area

Flakiness

net_stubbing_spec.ts Flakiness
1 network stubbing > intercepting request > can intercept utf-8 request bodies without crashing
2 network stubbing > waiting and aliasing > can timeout incrementally waiting on requests
xhr_spec.js Flakiness
1 src/cy/commands/xhr > abort > aborts xhrs currently in flight

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@jennifer-shehane jennifer-shehane requested review from kuceb and removed request for flotwig September 10, 2021 19:49
@jennifer-shehane jennifer-shehane merged commit f82c08e into develop Sep 15, 2021
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Sep 17, 2021

Released in 8.4.1.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v8.4.1, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Sep 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should use DRONE_SOURCE_BRANCH
2 participants