Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove legacy javascripts config option and related code #18101

Merged
merged 1 commit into from
Sep 16, 2021

Conversation

lmiller1990
Copy link
Contributor

  • Closes N/A

User facing changelog

Removes code relating to undocumented legacy javascripts config option.

Additional details

N/A

How has the user experience changed?

No change

PR Tasks

  • Have tests been added/updated?
  • Has the original issue or this PR been tagged with a release in ZenHub?
  • Has a PR for user-facing changes been opened in cypress-documentation?
  • Have API changes been updated in the type definitions?
  • Have new configuration options been added to the cypress.schema.json?

@lmiller1990 lmiller1990 requested a review from a team as a code owner September 15, 2021 05:19
@lmiller1990 lmiller1990 requested review from jennifer-shehane and kuceb and removed request for a team September 15, 2021 05:19
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Sep 15, 2021

Thanks for taking the time to open a PR!

@lmiller1990 lmiller1990 force-pushed the chore/remove-legacy-javascripts-config branch from 77703b4 to da74782 Compare September 15, 2021 05:32
@cypress
Copy link

cypress bot commented Sep 15, 2021



Test summary

8373 2 103 3Flakiness 4


Run details

Project cypress
Status Failed
Commit da74782
Started Sep 16, 2021 12:01 AM
Ended Sep 16, 2021 12:12 AM
Duration 10:44 💡
OS Linux Debian - 10.9
Browser Multiple

View run in Cypress Dashboard ➡️


Failures

e2e/focus_blur_spec.js Failed
1 intercept blur methods correctly > focus area
commands/actions/type_spec.js Failed
1 ... > element

Flakiness

cypress/proxy-logging-spec.ts Flakiness
1 Proxy Logging > request logging > fetch log shows resource type, url, method, and status code and has expected snapshots and consoleProps
2 Proxy Logging > request logging > fetch log shows resource type, url, method, and status code and has expected snapshots and consoleProps
commands/net_stubbing_spec.ts Flakiness
1 network stubbing > intercepting request > can intercept utf-8 request bodies without crashing
commands/xhr_spec.js Flakiness
1 src/cy/commands/xhr > abort > aborts xhrs currently in flight

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@ImCesar ImCesar self-requested a review September 15, 2021 22:23
@lmiller1990 lmiller1990 merged commit efb4062 into develop Sep 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants