-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add 'slowTestThreshold' and fix this.slow() inside specs #18496
feat: Add 'slowTestThreshold' and fix this.slow() inside specs #18496
Conversation
…Change to 10000ms default
…side tests, hooks and suites.
…shold inside tests, hooks and suites." This reverts commit 1496833.
Co-authored-by: Chris Breiding <chrisbreiding@users.noreply.github.com>
Thanks for taking the time to open a PR!
|
…e-slow-test-threshold
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're going to do a product review next week on this, so hold off on merging until then. I think it will be fine though.
…e-slow-test-threshold
...ages/server/test/support/fixtures/projects/e2e/cypress/integration/slowTestThreshold_spec.js
Outdated
Show resolved
Hide resolved
system-tests/projects/e2e/cypress/integration/slowTestThreshold_spec.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like some of the files from the unified branch made it into this PR - packages/app
, packages/frontend-shared
, etc.
Fixed. I've been having a weird issue where whenever I switch from unified-desktop-gui to a devlop-based branch, the unification work leaves behind a bunch of files. I usually manually remove them, but forgot this time (and then used |
@BlueWinds I think this is due to the files being generated when you switch to unified - and being part of their .gitignore, but when switching back to |
this.slow()
inside specs #18371, which targeted 9.0-release rather than develop, since these are not breaking changes.User facing changelog
slowTestThreshold
config option to customize slow test threshold."slowTestThreshold": 75
to your cypress configuration.Additional details
A test that executes for longer than the slowTestThreshold time will be highlighted in yellow with the default spec reporter. This is a visual change only - slow tests still pass.
PR Tasks
cypress-documentation
? Add documentation for new slowTestThreshold config option cypress-documentation#4145type definitions
?cypress.schema.json
?