chore: Update TypeScript to 4.4.4 #18930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for taking the time to open a PR!
|
sainthkh
requested review from
jennifer-shehane and
tbiethman
and removed request for
a team
| @@ -262,6 +262,8 @@ export class Header extends Component<HeaderProps> { | |||
|
|
|||
| if (!this._studioNeedsUrl) return | |||
|
|
|||
| // TODO: studio/studio-recorder.js should be converted to ts. And add proper type. | |||
There was a problem hiding this comment.
Can we log an issue for this work & add in the comment?
There was a problem hiding this comment.
I added more comment about it like this:
// Note: changes in TypeScript 4.4.4 made the code below fail the type check.
// @see https://github.com/cypress-io/cypress/pull/18930
// TODO: studio/studio-recorder.js should be converted to ts. And add proper type.
// @ts-ignoreThere was a problem hiding this comment.
I was thinking we'd log an issue to update studio/studio-recorder.js to be converted to typescript, not necessarily reference this PR. We should be able to find this PR reference in the git history.
There was a problem hiding this comment.
// Note: changes in TypeScript 4.4.4 made the code below fail the type check.
// ts interprets visitUrl below as (url: null | undefined) => never
// TODO: studio/studio-recorder.js should be converted to ts. And add proper type.
// @ts-ignoreI left why this studio/studio-recorder.js should be converted to ts.
sainthkh
force-pushed
the
update-ts-4.4.4
branch
from
6adf8ca
to
d159d53
Compare
mjhenkes
approved these changes
Nov 18, 2021
chrisbreiding
approved these changes
Nov 19, 2021
tgriesser
added a commit
that referenced
this pull request
Nov 20, 2021
* develop: (52 commits) feat: use hoisted yarn install in binary build (#17285) fix: compile npm packages for node 12 (#18989) fix: show call count even if `cy.stub().log(false)`. (#18907) chore: Update TypeScript to 4.4.4 (#18930) fix: wrap playground selectors in double quotes if not included (#18442) fix: flaky settings_spec test (#18979) chore: Update Chrome (stable) to 96.0.4664.45 (#18931) fix: Loading of specs with % in the filename (#18877) chore: refactor `create` into class `$Cy` (#18715) chore: Update Chrome (beta) to 96.0.4664.45 (#18891) fix: flaky `system-tests-firefox` job (#18848) chore: release @cypress/webpack-preprocessor-v5.10.0 chore: release @cypress/vue-v3.0.5 chore: release @cypress/schematic-v1.6.0 chore: release create-cypress-tests-v1.2.0 release 9.0.0 feat: ensure major release have conduit app wait on localhost:3000 fix install-required-node use --legacy-peer-deps ...
tgriesser
added a commit
that referenced
this pull request
Nov 21, 2021
* 10.0-release: (56 commits) chore: post-merge cleanup feat: use hoisted yarn install in binary build (#17285) fix: fix spec list header, "Create specs" prompt, add workspace recommended apollo extension (#18993) feat(unify): reporter settings (#18946) feat: add devServer to config file (#18962) fix: compile npm packages for node 12 (#18989) fix: show call count even if `cy.stub().log(false)`. (#18907) chore: Update TypeScript to 4.4.4 (#18930) fix: wrap playground selectors in double quotes if not included (#18442) fix: flaky settings_spec test (#18979) chore: Update Chrome (stable) to 96.0.4664.45 (#18931) fix: Loading of specs with % in the filename (#18877) chore: refactor `create` into class `$Cy` (#18715) chore: Update Chrome (beta) to 96.0.4664.45 (#18891) fix: flaky `system-tests-firefox` job (#18848) chore: release @cypress/webpack-preprocessor-v5.10.0 chore: release @cypress/vue-v3.0.5 chore: release @cypress/schematic-v1.6.0 chore: release create-cypress-tests-v1.2.0 release 9.0.0 ...
tgriesser
added a commit
that referenced
this pull request
Nov 21, 2021
…e-data-clean-refactor * tgriesser/chore/e2e-data-clean: (76 commits) chore: post-merge cleanup feat: use hoisted yarn install in binary build (#17285) fix: fix spec list header, "Create specs" prompt, add workspace recommended apollo extension (#18993) feat(unify): reporter settings (#18946) feat: add devServer to config file (#18962) fix: compile npm packages for node 12 (#18989) fix: show call count even if `cy.stub().log(false)`. (#18907) chore: Update TypeScript to 4.4.4 (#18930) feat: use fuzzy search (#18966) fix: onUnmounted warning in topnav (#18988) fix: wrap playground selectors in double quotes if not included (#18442) fix: flaky settings_spec test (#18979) fix: CYPRESS_INTERNAL_VITE_DEV for development feat: Create default config file (#18943) feat(app): support editor preference (#18932) chore: Update Chrome (stable) to 96.0.4664.45 (#18931) fix: Loading of specs with % in the filename (#18877) feat: improve vite DX (#18937) chore: refactor `create` into class `$Cy` (#18715) feat: Use plugins on config files (#18798) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User facing changelog
N/A
Additional details
Any implementation details to explain?
unknownfromany. It caused some errors. For more info => Add flag to changecatchvariables' default types tounknownmicrosoft/TypeScript#41013@types/jsdomand@types/filesystemto avoid type conflicts.react-vtree. It seems that some missing types are added to TypeScript.How has the user experience changed?
N/A
PR Tasks
N/A