Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update TypeScript to 4.4.4 #18930

Merged
merged 8 commits into from
Nov 19, 2021

Conversation

sainthkh
Copy link
Contributor

@sainthkh sainthkh commented Nov 16, 2021

  • Closes

User facing changelog

N/A

Additional details

  • Why was this change necessary? => Fix some new type changes.
  • What is affected by this change? => N/A

Any implementation details to explain?

How has the user experience changed?

N/A

PR Tasks

N/A

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Nov 16, 2021

Thanks for taking the time to open a PR!

@sainthkh sainthkh mentioned this pull request Nov 16, 2021
4 tasks
@sainthkh sainthkh marked this pull request as ready for review November 16, 2021 02:59
@sainthkh sainthkh requested a review from a team as a code owner November 16, 2021 02:59
@sainthkh sainthkh requested review from jennifer-shehane and tbiethman and removed request for a team November 16, 2021 02:59
@@ -262,6 +262,8 @@ export class Header extends Component<HeaderProps> {

if (!this._studioNeedsUrl) return

// TODO: studio/studio-recorder.js should be converted to ts. And add proper type.
Copy link
Member

@emilyrohrbough emilyrohrbough Nov 16, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we log an issue for this work & add in the comment?

Copy link
Contributor Author

@sainthkh sainthkh Nov 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added more comment about it like this:

// Note: changes in TypeScript 4.4.4 made the code below fail the type check.
// @see https://github.com/cypress-io/cypress/pull/18930
// TODO: studio/studio-recorder.js should be converted to ts. And add proper type.
// @ts-ignore

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking we'd log an issue to update studio/studio-recorder.js to be converted to typescript, not necessarily reference this PR. We should be able to find this PR reference in the git history.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

// Note: changes in TypeScript 4.4.4 made the code below fail the type check.
// ts interprets visitUrl below as (url: null | undefined) => never
// TODO: studio/studio-recorder.js should be converted to ts. And add proper type.
// @ts-ignore

I left why this studio/studio-recorder.js should be converted to ts.

@chrisbreiding chrisbreiding merged commit 2a6ded2 into cypress-io:develop Nov 19, 2021
tgriesser added a commit that referenced this pull request Nov 20, 2021
* develop: (52 commits)
  feat: use hoisted yarn install in binary build (#17285)
  fix: compile npm packages for node 12 (#18989)
  fix: show call count even if `cy.stub().log(false)`. (#18907)
  chore: Update TypeScript to 4.4.4 (#18930)
  fix: wrap playground selectors in double quotes if not included (#18442)
  fix: flaky settings_spec test (#18979)
  chore: Update Chrome (stable) to 96.0.4664.45 (#18931)
  fix: Loading of specs with % in the filename (#18877)
  chore: refactor `create` into class `$Cy` (#18715)
  chore: Update Chrome (beta) to 96.0.4664.45 (#18891)
  fix: flaky `system-tests-firefox` job (#18848)
  chore: release @cypress/webpack-preprocessor-v5.10.0
  chore: release @cypress/vue-v3.0.5
  chore: release @cypress/schematic-v1.6.0
  chore: release create-cypress-tests-v1.2.0
  release 9.0.0
  feat: ensure major release
  have conduit app wait on localhost:3000
  fix install-required-node
  use --legacy-peer-deps
  ...
tgriesser added a commit that referenced this pull request Nov 21, 2021
* 10.0-release: (56 commits)
  chore: post-merge cleanup
  feat: use hoisted yarn install in binary build (#17285)
  fix: fix spec list header, "Create specs" prompt, add workspace recommended apollo extension (#18993)
  feat(unify): reporter settings (#18946)
  feat: add devServer to config file (#18962)
  fix: compile npm packages for node 12 (#18989)
  fix: show call count even if `cy.stub().log(false)`. (#18907)
  chore: Update TypeScript to 4.4.4 (#18930)
  fix: wrap playground selectors in double quotes if not included (#18442)
  fix: flaky settings_spec test (#18979)
  chore: Update Chrome (stable) to 96.0.4664.45 (#18931)
  fix: Loading of specs with % in the filename (#18877)
  chore: refactor `create` into class `$Cy` (#18715)
  chore: Update Chrome (beta) to 96.0.4664.45 (#18891)
  fix: flaky `system-tests-firefox` job (#18848)
  chore: release @cypress/webpack-preprocessor-v5.10.0
  chore: release @cypress/vue-v3.0.5
  chore: release @cypress/schematic-v1.6.0
  chore: release create-cypress-tests-v1.2.0
  release 9.0.0
  ...
tgriesser added a commit that referenced this pull request Nov 21, 2021
…e-data-clean-refactor

* tgriesser/chore/e2e-data-clean: (76 commits)
  chore: post-merge cleanup
  feat: use hoisted yarn install in binary build (#17285)
  fix: fix spec list header, "Create specs" prompt, add workspace recommended apollo extension (#18993)
  feat(unify): reporter settings (#18946)
  feat: add devServer to config file (#18962)
  fix: compile npm packages for node 12 (#18989)
  fix: show call count even if `cy.stub().log(false)`. (#18907)
  chore: Update TypeScript to 4.4.4 (#18930)
  feat: use fuzzy search (#18966)
  fix: onUnmounted warning in topnav (#18988)
  fix: wrap playground selectors in double quotes if not included (#18442)
  fix: flaky settings_spec test (#18979)
  fix: CYPRESS_INTERNAL_VITE_DEV for development
  feat: Create default config file (#18943)
  feat(app): support editor preference (#18932)
  chore: Update Chrome (stable) to 96.0.4664.45 (#18931)
  fix: Loading of specs with % in the filename (#18877)
  feat: improve vite DX (#18937)
  chore: refactor `create` into class `$Cy` (#18715)
  feat: Use plugins on config files (#18798)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants