fix: change, input events are not fired when the same option is selected again.
#19623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for taking the time to open a PR!
|
sainthkh
requested review from
jennifer-shehane
and removed request for
a team
BlueWinds
suggested changes
Feb 4, 2022
sainthkh
commented
Feb 7, 2022
Comment on lines
-368
to
+387
| cy.get('#select-maps').select('de_dust2').select('de_aztec') | ||
| cy.get('#select-maps').select('de_aztec').select('de_dust2') |
There was a problem hiding this comment.
2 tests that use #select-maps have been changed because it tries to select the already-selected first option. I changed them to select the second one.
|
system-tests failed because CircleCI doesn't end some tests for me. It's also happening in #19837 |
tbiethman
approved these changes
Feb 7, 2022
BlueWinds
approved these changes
Feb 7, 2022
tgriesser
added a commit
that referenced
this pull request
Feb 14, 2022
* develop: feat: gray out the path to system node in cypress run header (#20121) feat: redesign server errors (#20072) test: fix awesome-typescript-loader test and remove test-binary job (#20131) fix: Fix issues with stack traces and command log in Chrome 99 (#20049) fix: `cy.type(' ')` fires click event on button-like elements. (#20067) fix: `change`, `input` events are not fired when the same option is selected again. (#19623) build: publish vue3 on latest (#20099) chore: release @cypress/webpack-preprocessor-v5.11.1 chore: release @cypress/webpack-dev-server-v1.8.1 fix: detect newly added specs in dev-server compilation (#17950) chore: Remove pkg/driver //@ts-nocheck part 3 (#19837) chore: set up semantic-pull-request GitHub Action (#20091) chore: release @cypress/react-v5.12.2 fix: remove nullish coalescing in js files to support node 12 (#20094) docs: update @cypress/webpack-preprocessor links (#19902) refactor: use aliases instead of meta (#19566)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User facing changelog
change,inputevents are not fired when the same option is selected again.Additional details
<option>is selected,change,inputevents are not be fired in browsers, but Cypress does.How has the user experience changed?
Before:
cy.selectdoesn't follow the browser behavior.After:
cy.selectfollows it.PR Tasks
cypress-documentation?type definitions?cypress.schema.json?