chore(multi-domain): adding websocket support for backend and automation requests #19843
Conversation
mschile
requested review from
jennifer-shehane
and removed request for
a team
|
Thanks for taking the time to open a PR!
|
mschile
requested review from
chrisbreiding,
AtofStryker and
mjhenkes
and removed request for
jennifer-shehane
|
Test summary
Run details
View run in Cypress Dashboard ➡️ Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
||||||||||||||||||||||||||
| @@ -28,10 +23,10 @@ context('multi-domain files', { experimentalSessionSupport: true, experimentalMu | |||
| }) | |||
| }) | |||
|
|
|||
| // FIXME: Cypress.backend.resolves is not a function | |||
| // Works when not using switchToDomain | |||
| // FIXME: stub on Cypress.backend is causing an infinite loop | |||
There was a problem hiding this comment.
The primary driver writeFile tests call through to the real implementation of Cypress.backend, so I guess they actually write the file. I think that's fine because we do intend the driver tests to often be e2e or integration tests.
It might not necessary to stub Cypress.backend here at all. I think we do it in the other tests primarily to test out when it fails and rejects, but just testing the happy path here is fine for now.
There was a problem hiding this comment.
It does call through in the beforeEach but in the actual it block, it calls .resolves() to mock the writeFile(). I doubt we want to actually write a file unless it was to a temp directory or maybe write to an existing file and check the modified date?
| // at eval(webpack:///../driver/src/cy/commands/task.ts?:72:78) | ||
| // From previous event: at task(webpack:///../driver/src/cy/commands/task.ts?:71:15) | ||
| it.skip('.task()', () => { | ||
| it('.task()', () => { |
There was a problem hiding this comment.
its nice to see all these tests getting enabled 🎉
…end-automation-request
chrisbreiding
changed the title
mschile
deleted the
issue-19767-multi-domain-backend-automation-request
branch
User facing changelog
n/a
Additional details
skipfor the following tests:getCookie(),getCookies(),setCookie,clearCookie(),clearCookies()fixture(),readFile()exec(),task()writeFile()test is failing due to an issue stubbingCypress.backend. This will need to be investigated further outside of this PR so the skip can be removed.How has the user experience changed?
User is not able to perform tasks that interact with the server.
PR Tasks
cypress-documentation?type definitions?cypress.schema.json?