Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(multi-domain): add clock support in multi-domain #19861

Merged
merged 1 commit into from
Jan 25, 2022

Conversation

mschile
Copy link
Contributor

@mschile mschile commented Jan 24, 2022

User facing changelog

n/a

Additional details

The following error thrown when accessing cy.clock() or cy.tick():

TypeError: Cannot set properties of undefined (setting 'clock')
  at Object.clock (webpack:///../driver/src/cy/commands/clock.ts?:170:17)

The state('ctx') object was not set in the secondary domain which caused the error. In the primary domain the state('ctx') is set to the runnable.ctx when the runnable is set. Thus, in the secondary domain, I'm setting the state('ctx') to the runnable.ctx when the state('runnable') is set.

How has the user experience changed?

Users are now able to use .clock() and .tick() in multi-domain.

PR Tasks

  • Have tests been added/updated?
  • [n/a] Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • [n/a] Has a PR for user-facing changes been opened in cypress-documentation?
  • [n/a] Have API changes been updated in the type definitions?
  • [n/a] Have new configuration options been added to the cypress.schema.json?

@mschile mschile requested a review from a team as a code owner January 24, 2022 23:59
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jan 24, 2022

Thanks for taking the time to open a PR!

@mschile mschile requested review from jennifer-shehane, chrisbreiding, AtofStryker and mjhenkes and removed request for a team and jennifer-shehane January 24, 2022 23:59
@chrisbreiding chrisbreiding changed the title chore (multi-domain): add clock support in multi-domain chore(multi-domain): add clock support in multi-domain Jan 25, 2022
Copy link
Contributor

@chrisbreiding chrisbreiding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright! Glad that was a simple fix 👍

@cypress
Copy link

cypress bot commented Jan 25, 2022



Test summary

4444 0 77 1Flakiness 0


Run details

Project cypress
Status Passed
Commit e3ebeaf
Started Jan 25, 2022 2:27 PM
Ended Jan 25, 2022 2:39 PM
Duration 12:25 💡
OS Linux Debian - 10.10
Browser Firefox 93

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@mschile mschile merged commit 2475b5a into feature-multidomain Jan 25, 2022
@mschile mschile deleted the issue-19846-multi-domain-clock branch January 25, 2022 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants