Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: pass correct spec URL in cypress run on Windows #19890

Merged
merged 2 commits into from
Jan 31, 2022
Merged

fix: pass correct spec URL in cypress run on Windows #19890

merged 2 commits into from
Jan 31, 2022

Conversation

flotwig
Copy link
Contributor

@flotwig flotwig commented Jan 25, 2022 •
edited
Loading

User facing changelog

Additional details

  • Without this change, the spec URL would be something like cypress/e2e/spec.ts, which would not match the backslashed paths on Windows.
    image
  • With this PR, the backslashes are retained in getSpecUrl.
  • Also removed extra normalization code - it doesn't seem like this did anything after removing the double slash from the constructed URL, and no tests failed after removing it.

How has the user experience changed?

PR Tasks

  • [no] Have tests been added/updated?
  • [na] Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • [na] Has a PR for user-facing changes been opened in cypress-documentation?
  • [na] Have API changes been updated in the type definitions?
  • [na] Have new configuration options been added to the cypress.schema.json?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jan 25, 2022

Thanks for taking the time to open a PR!

@flotwig flotwig changed the title [ fix(data-context): use posix paths in transformSpec Jan 25, 2022
@cypress
Copy link

cypress bot commented Jan 25, 2022 •
edited
Loading


Test summary

17937 • 0 • 216 • 0 • Flakiness 1

Run details
Project cypress
Status Passed
Commit c8b1c99
Started Jan 31, 2022 5:09 PM
Ended Jan 31, 2022 5:21 PM
Duration 12:16 💡
OS Linux Debian - 10.10
Browser Multiple

View run in Cypress Dashboard ➡️

Flakiness

cypress/e2e/commands/net_stubbing.cy.ts 1 Flakiness
1 network stubbing > waiting and aliasing > yields the expected interception when two requests are raced

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

Base automatically changed from unify-890-ebusy-eperm to 10.0-release January 26, 2022 19:39
@flotwig flotwig changed the title fix(data-context): use posix paths in transformSpec fix: pass correct spec URL in cypress run on Windows Jan 28, 2022
@flotwig flotwig force-pushed the unify-882-posix-spec-url branch 2 times, most recently from c85c4d4 to 12dcfff Compare January 31, 2022 16:39
@flotwig flotwig marked this pull request as ready for review January 31, 2022 16:41
elevatebart
elevatebart approved these changes Jan 31, 2022
View reviewed changes
Copy link
Contributor

@elevatebart elevatebart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea. tests are still failing but at least they are run.

Tested using

yarn workspace @packages/app cypress:run:e2e --headed

@ryanthemanuel
Copy link
Collaborator

yarn workspace @packages/app cypress:run:e2e --headed --browser=chrome is working for me. Looks good!

@flotwig flotwig merged commit 815fe3d into 10.0-release Jan 31, 2022
@flotwig flotwig deleted the unify-882-posix-spec-url branch January 31, 2022 17:52
tgriesser added a commit that referenced this pull request Feb 1, 2022
@tgriesser
Merge branch '10.0-release' into tgriesser/refactor/error-improvements
36e48c3 
* 10.0-release:
  fix: restore @lmiller1990's changes
  feat: styling snapshots (#19972)
  fix bad merge overrides- GOOD CATCH TYLER!
  fix(unify): Updating reporter to consistently use app-provided "Preferred Editor" dialog (#19933)
  fix: move node 17 Check from Binary to CLI (#19977)
  fix: pass correct spec URL in `cypress run` on Windows (#19890)
  fix: send click event with `cy.type('{enter}')`. (#19726)
  feat: detect package manager in wizard (#19960)
  fix: refactor set specs by specPattern (#19953)
  chore: Update Chrome (beta) to 98.0.4758.74
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryanthemanuel ryanthemanuel ryanthemanuel approved these changes

@elevatebart elevatebart elevatebart approved these changes

@ZachJW34 ZachJW34 ZachJW34 approved these changes

Assignees

@flotwig flotwig

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@flotwig @ryanthemanuel @elevatebart @ZachJW34