fix: pass correct spec URL in cypress run on Windows
#19890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for taking the time to open a PR!
|
|
Test summary
Run details
View run in Cypress Dashboard ➡️ Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
||||||||||||||||||||||||||
flotwig
force-pushed
the
unify-882-posix-spec-url
branch
from
a11a340 to
5f8c3cc
Compare
flotwig
force-pushed
the
unify-882-posix-spec-url
branch
from
f1b8854 to
c8fc04f
Compare
flotwig
changed the title
cypress run on Windows
flotwig
force-pushed
the
unify-882-posix-spec-url
branch
2 times, most recently
from
c85c4d4 to
12dcfff
Compare
elevatebart
approved these changes
Jan 31, 2022
ZachJW34
approved these changes
Jan 31, 2022
|
yarn workspace @packages/app cypress:run:e2e --headed --browser=chrome is working for me. Looks good! |
ryanthemanuel
approved these changes
Jan 31, 2022
tgriesser
added a commit
that referenced
this pull request
Feb 1, 2022
* 10.0-release: fix: restore @lmiller1990's changes feat: styling snapshots (#19972) fix bad merge overrides- GOOD CATCH TYLER! fix(unify): Updating reporter to consistently use app-provided "Preferred Editor" dialog (#19933) fix: move node 17 Check from Binary to CLI (#19977) fix: pass correct spec URL in `cypress run` on Windows (#19890) fix: send click event with `cy.type('{enter}')`. (#19726) feat: detect package manager in wizard (#19960) fix: refactor set specs by specPattern (#19953) chore: Update Chrome (beta) to 98.0.4758.74
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User facing changelog
Additional details
cypress/e2e/spec.ts, which would not match the backslashed paths on Windows.getSpecUrl.How has the user experience changed?
PR Tasks
windows-run-app-integration-tests-chromejob runningcypress:runin CircleCI Windows.cypress-documentation?type definitions?cypress.schema.json?