Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Migrate more runner UI specs to app #20118

Merged
merged 76 commits into from
Feb 18, 2022
Merged
Show file tree
Hide file tree
Changes from 71 commits
Commits
Show all changes
76 commits
Select commit Hold shift + click to select a range
46bf1ef
Adding remaining reporter error tests.
tbiethman Feb 1, 2022
250a973
Removing existing integration spec file
tbiethman Feb 1, 2022
4e89fef
Removing existing runner fixtures for error specs
tbiethman Feb 1, 2022
5a3a2fb
Fixing ts lint
tbiethman Feb 1, 2022
ccd5135
Testing with less tests kept in memory
tbiethman Feb 2, 2022
23073e7
Merge branch '10.0-release' of https://github.com/cypress-io/cypress …
tbiethman Feb 2, 2022
3591fbb
Testing some cypress-in-cypress settings to improve run-mode performa…
tbiethman Feb 2, 2022
ce12a8a
Reverting changes to doc_url specs
tbiethman Feb 3, 2022
6ca17ec
PR Updates. Inverting default value for 'open in IDE' validation in a…
tbiethman Feb 3, 2022
231f651
Cleaning up ported code
tbiethman Feb 3, 2022
ebe76d0
Update system-tests/projects/runner-e2e-specs/cypress/fixtures/index.…
tbiethman Feb 3, 2022
7369e9d
Trying build workaround
tbiethman Feb 3, 2022
71c572d
Bumping up parallelized builds for app integration tests
tbiethman Feb 3, 2022
984d81f
Removing suspicious tests to validate CI build
tbiethman Feb 3, 2022
aeb235e
Removing more suspicious tests to test CI
tbiethman Feb 3, 2022
532da7b
Trying to not scaffold every navigation
tbiethman Feb 3, 2022
e2ae1e5
Bumping resources for run-app-integration job. Updating reporter.erro…
tbiethman Feb 4, 2022
51f3924
Couple API tweaks
tbiethman Feb 4, 2022
617e1dd
Merge branch '10.0-release' into runner-e2e-round-2
tbiethman Feb 4, 2022
fbfa384
test: Migrating runner hooks specs to app
tbiethman Feb 7, 2022
833c52b
Merge branch '10.0-release' of https://github.com/cypress-io/cypress …
tbiethman Feb 7, 2022
ea71923
Removing unused helper from runner package; cleaning up a few things
tbiethman Feb 7, 2022
6890597
Updating yarn.lock
tbiethman Feb 7, 2022
d9175c6
Merge branch 'runner-e2e-round-2' of https://github.com/cypress-io/cy…
tbiethman Feb 7, 2022
f0433c5
fix: Migrating runner sessions ui tests to app
tbiethman Feb 7, 2022
340a829
test: Migrating runner's runner.ui tests to app
tbiethman Feb 7, 2022
7d1e738
test: Migrating runner retries ui tests to app
tbiethman Feb 9, 2022
48c6640
Merge branch '10.0-release' of https://github.com/cypress-io/cypress …
tbiethman Feb 9, 2022
cb03057
Cleaning up a few things for consistency
tbiethman Feb 9, 2022
cb0e1e5
Fixing ts errors
tbiethman Feb 9, 2022
bb0b722
Removing tests for runner header that have existing coverage in app
tbiethman Feb 9, 2022
f8dbc54
Working around detached elements in CI
tbiethman Feb 9, 2022
9c11c49
Still working around detached elements in CI
tbiethman Feb 10, 2022
b3dc1c8
Updating sessions.ui test to click more carefully. Adding bit more co…
tbiethman Feb 10, 2022
4df910c
Update packages/app/cypress/e2e/runner/retries.ui.cy.ts
tbiethman Feb 10, 2022
0c96a74
Merge branch '10.0-release' of https://github.com/cypress-io/cypress …
tbiethman Feb 11, 2022
f1431ab
Migrating issue specs. Updating TODOs. Hopefully addressing some flake.
tbiethman Feb 11, 2022
4c4712f
Merge branch '10.0-release' into runner-e2e-round-3
tbiethman Feb 11, 2022
cb6303b
Stopping icon spin animation for percy snapshots
tbiethman Feb 11, 2022
f11a98a
WIP
tbiethman Feb 11, 2022
7462254
customPercyCommand.ts
tbiethman Feb 11, 2022
232f13f
WIP: working on custom percy snapshots for hiding elements other than…
brian-mann Feb 11, 2022
cc348a0
WIP: Adding naive mutation observer for reseting DOM mutations after …
tbiethman Feb 12, 2022
a3e260a
Implementing scoped snapshots throughout app/runner tests, let's see …
tbiethman Feb 13, 2022
ee24b61
Merge branch '10.0-release' into runner-e2e-round-3
tbiethman Feb 13, 2022
f9c4f1c
Adding more snapshots to runner tests.
tbiethman Feb 13, 2022
d364b55
Using spec link as click target
tbiethman Feb 14, 2022
9144877
Stop taking snapshots of failed tests
tbiethman Feb 14, 2022
84a729a
Scoping selector playground snapshots (though they're still unstyled)
tbiethman Feb 14, 2022
4547b3f
Addressing flake in virtualized spec list
tbiethman Feb 14, 2022
d909f42
Drying up runner snapshotting
tbiethman Feb 14, 2022
17abe39
Logging single percy snapshot that reflects proper viewport and overr…
tbiethman Feb 14, 2022
efd8378
Merge branch '10.0-release' into runner-e2e-round-3
tbiethman Feb 14, 2022
7e22330
Updating describes to better match previous snapshot names
tbiethman Feb 15, 2022
7d7b651
Removing added snapshots to get more accurate better diff presentatio…
tbiethman Feb 15, 2022
30a5fde
Removing new runner.ui snapshots as well
tbiethman Feb 15, 2022
33573c8
Adding a few PR recommendations. Updating one last spec name that was…
tbiethman Feb 16, 2022
f3ca37e
Updating to use anticipated default width for reporter
tbiethman Feb 16, 2022
07a599b
Updating tests for consistency with previous snapshots
tbiethman Feb 16, 2022
7b4b34e
Tying original command into promise chain
tbiethman Feb 16, 2022
944e0fb
Let's try that again
tbiethman Feb 16, 2022
faefa58
Making percy command enqueuing explicit to test result
tbiethman Feb 16, 2022
a9aa830
Scoping down on some variables. Using defaults for sessions tests.
tbiethman Feb 16, 2022
3d1fc8c
Updating some overrides to see if visibility is handled inconsistently
tbiethman Feb 16, 2022
ea77891
Whitespace vanquished, working session test updates back in for long …
tbiethman Feb 16, 2022
b526887
Viewport height is not reflected in snapshots, let's try forcing the …
tbiethman Feb 17, 2022
279dae3
Forcing the height issue
tbiethman Feb 17, 2022
813250e
Let's try a minHeight on the percy command
tbiethman Feb 17, 2022
d932a86
Cleaning up alterations made during percy exploration
tbiethman Feb 17, 2022
d6e148e
Merge branch '10.0-release' into runner-e2e-round-3
tbiethman Feb 17, 2022
1836767
Trying to get a cleaner percy diff after merge
tbiethman Feb 17, 2022
4b45599
Merge branch '10.0-release' into runner-e2e-round-3
tbiethman Feb 17, 2022
e7ecae3
Fix Percy to use 10.0-release branch as baseline image comparison
emilyrohrbough Feb 16, 2022
c045c41
add comments about temporary percy env vars
brian-mann Feb 17, 2022
139ca03
Merge branch 'runner-e2e-round-3' of https://github.com/cypress-io/cy…
brian-mann Feb 17, 2022
9eb5ffb
Adding some doc for changes made to customPercyCommand
tbiethman Feb 18, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/app/cypress/component/support/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ import { createPinia } from '../../../src/store'
import { setActivePinia } from 'pinia'
import type { Pinia } from 'pinia'
import 'cypress-real-events/support'
import installCustomPercyCommand from '@packages/ui-components/cypress/support/customPercyCommand'
import { installCustomPercyCommand } from '@packages/ui-components/cypress/support/customPercyCommand'

let pinia: Pinia

Expand Down
9 changes: 5 additions & 4 deletions packages/app/cypress/e2e/cypress-in-cypress-component.cy.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import defaultMessages from '@packages/frontend-shared/src/locales/en-US.json'
import { snapshotAUTPanel } from './support/snapshot-aut-panel'

describe('Cypress In Cypress', { viewportWidth: 1200 }, () => {
beforeEach(() => {
Expand All @@ -23,19 +24,19 @@ describe('Cypress In Cypress', { viewportWidth: 1200 }, () => {
cy.contains('Firefox').should('be.visible')
cy.findByTestId('viewport').click()

cy.percySnapshot('browsers open')
snapshotAUTPanel('browsers open')
cy.contains('Firefox').should('be.hidden')
cy.contains('The viewport determines the width and height of your application. By default the viewport will be 500px by 500px for Component Testing unless specified by a cy.viewport command.')
.should('be.visible')

cy.percySnapshot('viewport info open')
snapshotAUTPanel('viewport info open')

cy.get('body').click()

cy.findByTestId('playground-activator').click()
cy.findByTestId('playground-selector').clear().type('#__cy_root')

cy.percySnapshot('cy.get selector')
snapshotAUTPanel('cy.get selector')

cy.findByTestId('playground-num-elements').contains('1 Match')

Expand All @@ -49,7 +50,7 @@ describe('Cypress In Cypress', { viewportWidth: 1200 }, () => {

cy.findByTestId('playground-selector').clear().type('Component Test')

cy.percySnapshot('cy.contains selector')
snapshotAUTPanel('cy.contains selector')

cy.findByTestId('playground-num-elements').contains('1 Match')
})
Expand Down
9 changes: 5 additions & 4 deletions packages/app/cypress/e2e/cypress-in-cypress-e2e.cy.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import defaultMessages from '@packages/frontend-shared/src/locales/en-US.json'
import { snapshotAUTPanel } from './support/snapshot-aut-panel'

describe('Cypress In Cypress', { viewportWidth: 1200 }, () => {
beforeEach(() => {
Expand All @@ -23,19 +24,19 @@ describe('Cypress In Cypress', { viewportWidth: 1200 }, () => {
cy.contains('Firefox').should('be.visible')
cy.findByTestId('viewport').click()

cy.percySnapshot('browsers open')
snapshotAUTPanel('browsers open')
cy.contains('Firefox').should('be.hidden')
cy.contains('The viewport determines the width and height of your application. By default the viewport will be 1000px by 660px for End-to-end Testing unless specified by a cy.viewport command.')
.should('be.visible')

cy.percySnapshot('viewport info open')
snapshotAUTPanel('viewport info open')

cy.get('body').click()

cy.findByTestId('playground-activator').click()
cy.findByTestId('playground-selector').clear().type('li')

cy.percySnapshot('cy.get selector')
snapshotAUTPanel('cy.get selector')

cy.findByTestId('playground-num-elements').contains('3 Matches')

Expand All @@ -44,7 +45,7 @@ describe('Cypress In Cypress', { viewportWidth: 1200 }, () => {

cy.findByTestId('playground-selector').clear().type('Item 1')

cy.percySnapshot('cy.contains selector')
snapshotAUTPanel('cy.contains selector')

cy.findByTestId('playground-num-elements').contains('1 Match')

Expand Down
Original file line number Diff line number Diff line change
@@ -1,15 +1,13 @@
const helpers = require('../../support/helpers')

const { createCypress } = helpers
const { runIsolatedCypress } = createCypress()
import { loadSpec } from '../support/spec-loader'

// https://github.com/cypress-io/cypress/issues/18042
describe('issue 18042', () => {
beforeEach(function () {
return runIsolatedCypress(`cypress/fixtures/issues/issue-18042.js`)
})

it('Call count is shown even if cy.stub().log(false)', function () {
loadSpec({
fileName: 'issue-18042.cy.js',
passCount: 1,
})

cy.contains('Spies / Stubs (1)').click()
cy.get('.call-count').eq(1).should('have.text', '1')
})
Expand Down
14 changes: 14 additions & 0 deletions packages/app/cypress/e2e/runner/issues/issue-9162.cy.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
import { loadSpec } from '../support/spec-loader'

// https://github.com/cypress-io/cypress/issues/9162
describe('issue 9162', () => {
it('tests does not hang even if there is a fail in before().', function () {
loadSpec({
fileName: 'issue-9162.cy.js',
passCount: 0,
failCount: 1,
})

cy.contains('expected true to be false')
})
})
Loading