fix: migration ui differences #20134

ImCesar · 2022-02-10T01:07:39Z

See UNIFY-1053 for list of defects to be fixed

Closes UNIFY-1053

PR Tasks

Have tests been added/updated?
Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
Has a PR for user-facing changes been opened in cypress-documentation?
Have API changes been updated in the type definitions?
Have new configuration options been added to the cypress.schema.json?

cypress-bot · 2022-02-10T01:07:41Z

Thanks for taking the time to open a PR!

Create a Draft Pull Request if your PR is not ready for review. Mark the PR as Ready for Review when you're ready for a Cypress team member to review the PR.
Become familiar with the Code Review Checklist for guidelines on coding standards and what needs to be done before a PR can be merged.

cypress · 2022-02-10T01:21:42Z

Test summary

4381 • 0 • 51 • 0 • 0

Run details


Project	cypress
Status	Passed
Commit	`b21cb72`
Started	Feb 14, 2022 8:45 PM
Ended	Feb 14, 2022 8:57 PM
Duration	11:54 💡
OS	Linux Debian - 10.10
Browser	Chrome beta 98

View run in Cypress Dashboard ➡️

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

tbiethman · 2022-02-11T04:01:31Z

packages/data-context/test/unit/code-generator.spec.ts

@@ -244,7 +244,7 @@ describe('code-generator', () => {
    }).not.throw()
  })

-  it('should generate from scaffoldIntegration', async () => {
+  xit('should generate from scaffoldIntegration', async () => {


Should this be disabled? Can we put a comment here if so?

Fixed it up, this test is in a weird place since cypress-kitchensink is not using e2e, but still integration, or at least the one on npm.

into fix-migration-ui

elevatebart · 2022-02-11T23:28:24Z

packages/data-context/__snapshots__/migration.spec.ts.js

+    // We've imported your old cypress plugins here.
+    // You may want to clean this up later by importing these.


Suggested change

// We've imported your old cypress plugins here.

// You may want to clean this up later by importing these.

// We've required your old cypress plugins here.

// You may want to import these at the top of the file

// or replace the `require` statement with the contents of the file required

I don't know if I want to change the wording on this. This came from feedback and they seem particular on their wording (hence some of the changes here).

We've imported your old cypress here

I don't see any import keywords in the code below, how can we convey that we are executing it.

by importing these

That is the part that is really bugging me.
What are "these" that I can import. I only see one file.
Did you just tell me that you did that for me? I do not understand what I read.

Details

parent 6279a7d author Brian Mann <brian.mann86@gmail.com> 1644881743 -0500 committer Tim Griesser <tgriesser10@gmail.com> 1645497717 -0500 chore: post merge cleanup add visual tests for new errors, update formatting + copy of existing errors to bring into parity with new conventions fix require, lazy load if necessary export what is called directly to avoid circular ref proxy that's unstubbable export additional properties on error, update refs, fix tests fix missing ref rename clone -> cloneErr use proper method call fix: types for config changes fix: clean up a few test failures fix: additional cleanup of errors following merge fix: cleanup a few more tests/snapshot errors feat: reconfigure project from testing type card (#20109) fix: remove inner scroll from BaseError (#20104) feat: package manager in update modal (#20123) fix: Backing out driver change for type (#20155) * fix: Backing out driver change for type * Adding comment for posterity * Fixing test feat: detect component testing env (#20002) Co-authored-by: Zachary Williams <ZachJW34@gmail.com> Co-authored-by: Lachlan Miller <lachlan.miller.1990@outlook.com> fix: use github.com qualified path to deal with yarn cache bug (#20158) feat: Update version checking logic to query the manifest and ensure ctx.util.fetch can handle a proxy (#20107) Co-authored-by: Zach Bloomquist <git@chary.us> fix: cleanup integration folder after moving specs to e2e (#20149) Co-authored-by: Barthélémy Ledoux <bart@cypress.io> Co-authored-by: ElevateBart <ledouxb@gmail.com> fix: Remove mention of Cypress Studio from Experimental Project Settings (#20154) fix: remove phantom migration watchers (#20180) fix: migration ui differences (#20134) Co-authored-by: Lachlan Miller <lachlan.miller.1990@outlook.com> Co-authored-by: Barthélémy Ledoux <bart@cypress.io> test: use async copy for scaffolding project (#20181) fix: migration on windows (#20063) Co-authored-by: Zach Bloomquist <git@chary.us> Co-authored-by: Ryan Manuel <ryanm@cypress.io> test: clean up scaffoldMigrationProject (#20203) fix: rename folder instead of skip on migration (#20145) Co-authored-by: Emily Rohrbough <emilyrohrbough@users.noreply.github.com> Co-authored-by: Lachlan Miller <lachlan.miller.1990@outlook.com> chore: ignore checksums when installing Chrome in Windows CI (#20210) feat(unify): inline specs list tweaks (#20157) test: fix some windows tests (#20225) test(unify): Settings E2E Tests (#20126) Co-authored-by: Zachary Williams <ZachJW34@gmail.com> fix: migration hover/focus states (#20243) Co-authored-by: ElevateBart <ledouxb@gmail.com> fix: refactor function getFilesByGlob to use concat instead of isArray (#20245) * fix: avoid using Array.isArray when possible * fix: add one more refactoring Co-authored-by: Zachary Williams <ZachJW34@gmail.com> Co-authored-by: Zachary Williams <ZachJW34@gmail.com> test: Migrate more runner UI specs to app (#20118) * Adding remaining reporter error tests. * Removing existing integration spec file * Removing existing runner fixtures for error specs * Fixing ts lint * Testing with less tests kept in memory * Testing some cypress-in-cypress settings to improve run-mode performance. * Reverting changes to doc_url specs * PR Updates. Inverting default value for 'open in IDE' validation in an attempt to reduce test time. * Cleaning up ported code * Update system-tests/projects/runner-e2e-specs/cypress/fixtures/index.html Co-authored-by: Emily Rohrbough <emilyrohrbough@users.noreply.github.com> * Trying build workaround * Bumping up parallelized builds for app integration tests * Removing suspicious tests to validate CI build * Removing more suspicious tests to test CI * Trying to not scaffold every navigation * Bumping resources for run-app-integration job. Updating reporter.errors specs to appropriately reduce AUT refreshes. * Couple API tweaks * test: Migrating runner hooks specs to app * Removing unused helper from runner package; cleaning up a few things * Updating yarn.lock * fix: Migrating runner sessions ui tests to app * test: Migrating runner's runner.ui tests to app * test: Migrating runner retries ui tests to app * Cleaning up a few things for consistency * Fixing ts errors * Removing tests for runner header that have existing coverage in app * Working around detached elements in CI * Still working around detached elements in CI * Updating sessions.ui test to click more carefully. Adding bit more coverage around runner header and snapshot pinning. * Update packages/app/cypress/e2e/runner/retries.ui.cy.ts Co-authored-by: Ryan Manuel <ryanm@cypress.io> * Migrating issue specs. Updating TODOs. Hopefully addressing some flake. * Stopping icon spin animation for percy snapshots * WIP * customPercyCommand.ts * WIP: working on custom percy snapshots for hiding elements other than the reporter [skip ci] * WIP: Adding naive mutation observer for reseting DOM mutations after snapshots [skip ci] Got tired of tripping over types, I can add them when we're feature complete * Implementing scoped snapshots throughout app/runner tests, let's see how percy output looks * Adding more snapshots to runner tests. * Using spec link as click target * Stop taking snapshots of failed tests * Scoping selector playground snapshots (though they're still unstyled) * Addressing flake in virtualized spec list * Drying up runner snapshotting * Logging single percy snapshot that reflects proper viewport and overrides * Updating describes to better match previous snapshot names * Removing added snapshots to get more accurate better diff presentation in Percy * Removing new runner.ui snapshots as well * Adding a few PR recommendations. Updating one last spec name that was corrected for grammar and no longer matched. Updating/removing relevant TODOs. * Updating to use anticipated default width for reporter * Updating tests for consistency with previous snapshots * Tying original command into promise chain * Let's try that again * Making percy command enqueuing explicit to test result * Scoping down on some variables. Using defaults for sessions tests. * Updating some overrides to see if visibility is handled inconsistently * Whitespace vanquished, working session test updates back in for long command logs * Viewport height is not reflected in snapshots, let's try forcing the height on the panel * Forcing the height issue * Let's try a minHeight on the percy command * Cleaning up alterations made during percy exploration * Trying to get a cleaner percy diff after merge * Fix Percy to use 10.0-release branch as baseline image comparison * add comments about temporary percy env vars * Adding some doc for changes made to customPercyCommand Co-authored-by: Emily Rohrbough <emilyrohrbough@users.noreply.github.com> Co-authored-by: Ryan Manuel <ryanm@cypress.io> Co-authored-by: Brian Mann <brian.mann86@gmail.com> Co-authored-by: Emily Rohrbough <emilyrohrbough@yahoo.com> feat(unify): show spec runner header in run mode (#20189) Co-authored-by: Emily Rohrbough <emilyrohrbough@users.noreply.github.com> Co-authored-by: Zachary Williams <ZachJW34@gmail.com> Co-authored-by: Lachlan Miller <lachlan.miller.1990@outlook.com> fix: connect to dashboard page when there are no existing projects (#20188) Co-authored-by: Barthélémy Ledoux <bart@cypress.io> chore: fix system-test-firefox screenshots_spec flake (#20260) fix all the tests that escape "doesn\'t" to use string templates fix test assertion fix test importing wrong strip_indent fix snapshot remove accidental system test it.only properly skip describe suites + tests and add TODO comments export errors.theme, update imports not to require from deep inside packages export stripAnsi onto the old errors object fix yarn.lock chore: remove system test it.only and prevent CI from ever running onlys (#20276) * remove accidental system test it.only * prevent system tests from running in CI if set to run exclusively with it.only(...) chore: fix server performance flake (#20280) * chore: fix server performance flake * rerun in circle Co-authored-by: Brian Mann <brian.mann86@gmail.com> fix invalid exports remove fixtures after shutting down the project add terminals app watch command updated snapshots, added tests to cover --spec CLI arg + custom specPattern config - removed unused system project update deep import of @packages/errors fix root system test & launchpad choose-a-browser spec fix: skip test that is no longer correct in 10.x fix: serialize details when serializing the error remove plugins file not found error/test update CONFIG_FILE_REQUIRE_ERROR working through mapping error cases from develop Fixing CONFIG_VALIDATION_ERROR / SETUP_NODE_EVENTS_IS_NOT_FUNCTION errors fix remaining test failures fix spec failures Attempt to fix awesome-typescript-loader failures fix snapshot feat(unify): Login error states (#20204) feat: Updating reporter panel's default width to match new designs (#20231) * feat: Updating default reporter width to 450px * Updating component tests to account for new default panel 2 width * Giving the cypress-in-cypress tests a little more room to breath * Updating trigger test coordinate assertions to be have consistent results regardless of AUT scaling * Updating scale assertion now that available width has changed

* 10.0-release: (29 commits) feat: Updating reporter panel's default width to match new designs (#20231) feat(unify): Login error states (#20204) chore: fix server performance flake (#20280) chore: remove system test it.only and prevent CI from ever running onlys (#20276) chore: fix system-test-firefox screenshots_spec flake (#20260) fix: connect to dashboard page when there are no existing projects (#20188) feat(unify): show spec runner header in run mode (#20189) test: Migrate more runner UI specs to app (#20118) fix: refactor function getFilesByGlob to use concat instead of isArray (#20245) fix: migration hover/focus states (#20243) test(unify): Settings E2E Tests (#20126) test: fix some windows tests (#20225) feat(unify): inline specs list tweaks (#20157) chore: ignore checksums when installing Chrome in Windows CI (#20210) fix: rename folder instead of skip on migration (#20145) test: clean up scaffoldMigrationProject (#20203) fix: migration on windows (#20063) test: use async copy for scaffolding project (#20181) fix: migration ui differences (#20134) fix: remove phantom migration watchers (#20180) ...

fix ui issues

75ec48c

ImCesar requested review from elevatebart and lmiller1990 February 10, 2022 01:07

lmiller1990 and others added 3 commits February 10, 2022 20:47

correct workflow for component testing

e57a903

update tests

577a77c

Merge branch '10.0-release' into fix-migration-ui

6fd3c0f

ImCesar requested a review from tbiethman February 10, 2022 15:29

Merge branch '10.0-release' into fix-migration-ui

15021eb

ImCesar marked this pull request as ready for review February 10, 2022 18:16

Cesar added 3 commits February 10, 2022 15:14

Merge branch '10.0-release' into fix-migration-ui

aa6b17d

Merge branch '10.0-release' into fix-migration-ui

e158075

Merge branch '10.0-release' into fix-migration-ui

63f4e19

tbiethman reviewed Feb 11, 2022

View reviewed changes

lmiller1990 added 2 commits February 11, 2022 14:14

fix test

ae16f30

Merge branch 'fix-migration-ui' of https://github.com/cypress-io/cypress

400c322

into fix-migration-ui

lmiller1990 previously approved these changes Feb 11, 2022

View reviewed changes

tbiethman previously approved these changes Feb 11, 2022

View reviewed changes

Barthélémy Ledoux and others added 5 commits February 10, 2022 22:42

Merge branch '10.0-release' into fix-migration-ui

c762b7e

Merge branch '10.0-release' into fix-migration-ui

ed7e957

Merge branch '10.0-release' into fix-migration-ui

acb4869

Merge branch '10.0-release' into fix-migration-ui

4a2db06

Merge branch '10.0-release' into fix-migration-ui

1eb8c7e

elevatebart reviewed Feb 11, 2022

View reviewed changes

Cesar added 2 commits February 14, 2022 10:47

Merge branch '10.0-release' into fix-migration-ui

82c8fa7

remove e2e rename

319fb4b

ImCesar dismissed stale reviews from tbiethman and lmiller1990 via 319fb4b February 14, 2022 18:10

Merge branch '10.0-release' into fix-migration-ui

b21cb72

elevatebart approved these changes Feb 14, 2022

View reviewed changes

tbiethman approved these changes Feb 14, 2022

View reviewed changes

ImCesar merged commit 3103442 into 10.0-release Feb 14, 2022

ImCesar deleted the fix-migration-ui branch February 14, 2022 21:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: migration ui differences #20134

fix: migration ui differences #20134

ImCesar commented Feb 10, 2022 •

edited by lmiller1990

Loading

cypress-bot bot commented Feb 10, 2022

cypress bot commented Feb 10, 2022 •

edited

Loading

tbiethman Feb 11, 2022

lmiller1990 Feb 11, 2022 •

edited

Loading

lmiller1990 Feb 11, 2022

elevatebart Feb 11, 2022 •

edited

Loading

ImCesar Feb 11, 2022

elevatebart Feb 14, 2022 •

edited

Loading

		// We've imported your old cypress plugins here.
		// You may want to clean this up later by importing these.

-    // We've imported your old cypress plugins here.
-    // You may want to clean this up later by importing these.
+    // We've required your old cypress plugins here.
+    // You may want to import these at the top of the file
+    // or replace the `require` statement with the contents of the file required

fix: migration ui differences #20134

fix: migration ui differences #20134

Conversation

ImCesar commented Feb 10, 2022 • edited by lmiller1990 Loading

PR Tasks

cypress-bot bot commented Feb 10, 2022

cypress bot commented Feb 10, 2022 • edited Loading

Test summary

Run details

tbiethman Feb 11, 2022

Choose a reason for hiding this comment

lmiller1990 Feb 11, 2022 • edited Loading

Choose a reason for hiding this comment

lmiller1990 Feb 11, 2022

Choose a reason for hiding this comment

elevatebart Feb 11, 2022 • edited Loading

Choose a reason for hiding this comment

ImCesar Feb 11, 2022

Choose a reason for hiding this comment

elevatebart Feb 14, 2022 • edited Loading

Choose a reason for hiding this comment

ImCesar commented Feb 10, 2022 •

edited by lmiller1990

Loading

cypress bot commented Feb 10, 2022 •

edited

Loading

lmiller1990 Feb 11, 2022 •

edited

Loading

elevatebart Feb 11, 2022 •

edited

Loading

elevatebart Feb 14, 2022 •

edited

Loading