test: fix system-tests-firefox downloads flake

[ryanthemanuel]

User facing changelog

n/a

Additional details

There was a change made on the multi domain branch to fix a flake. The purpose of this change was to ensure that we are waiting for the download of the csv file before we check its contents.

Unfortunately, this left an additional flake. That flake was caused because we were downloading the same file multiple times in different tests and thus the second one actually gets placed at records(1).csv. In addition, the first file download doesn't have the fix that the second file download has so the file is not guaranteed to be downloaded. Therefore when the second test executes it's actually reading the location of the first test's download which may or may not be there.

To fix the second flake, we will limit the test that are run to just download_spec since that is the only test necessary to test switching download locations. Also, since readFile actually will retry until all chained assertions pass, the first fix is no longer necessary and that both flakes will be resolved if we just limit the tests being run to download_spec in this scenario.

How has the user experience changed?

n/a

PR Tasks

• Have tests been added/updated?
• [na] Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
• [na] Has a PR for user-facing changes been opened in cypress-documentation?
• [na] Have API changes been updated in the type definitions?
• [na] Have new configuration options been added to the cypress.schema.json?

[cypress-bot]

Thanks for taking the time to open a PR!

• Create a Draft Pull Request if your PR is not ready for review. Mark the PR as Ready for Review when you're ready for a Cypress team member to review the PR.
• Become familiar with the Code Review Checklist for guidelines on coding standards and what needs to be done before a PR can be merged.

[cypress]

---

Test summary

9265 • 0 • 156 • 2 • 2

---

Run details

Project	cypress
Status	Passed
Commit	83d42b9
Started	Mar 10, 2022 7:33 PM
Ended	Mar 10, 2022 7:45 PM
Duration	12:35 💡
OS	Linux Debian - 10.10
Browser	Multiple

View run in Cypress Dashboard ➡️

---

Flakiness

	cypress/integration/commands/net_stubbing_spec.ts		2
1	network stubbing > intercepting response > can 'delay' a proxy response using Promise.delay
2	network stubbing > waiting and aliasing > can timeout waiting on a single request using "alias.request"

---

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard