Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: [Multi-domain] Handle stability with delayed navigation #20642

Merged
merged 6 commits into from
Mar 16, 2022

Conversation

mjhenkes
Copy link
Member

  • Closes

User facing changelog

n/a

Additional details

This PR closes a gap where a page becomes unstable after entering a switch to domain command.

How has the user experience changed?

PR Tasks

  • Have tests been added/updated?
  • Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • Has a PR for user-facing changes been opened in cypress-documentation?
  • Have API changes been updated in the type definitions?
  • Have new configuration options been added to the cypress.schema.json?

@mjhenkes mjhenkes added the topic: cy.origin Problems or enhancements related to cy.origin command label Mar 16, 2022
@mjhenkes mjhenkes self-assigned this Mar 16, 2022
@mjhenkes mjhenkes requested a review from a team as a code owner March 16, 2022 14:29
@mjhenkes mjhenkes removed the request for review from a team March 16, 2022 14:29
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Mar 16, 2022

Thanks for taking the time to open a PR!

@cypress
Copy link

cypress bot commented Mar 16, 2022



Test summary

20487 0 298 4Flakiness 2


Run details

Project cypress
Status Passed
Commit a27f867
Started Mar 16, 2022 5:43 PM
Ended Mar 16, 2022 5:57 PM
Duration 14:00 💡
OS Linux Debian - 10.10
Browser Multiple

View run in Cypress Dashboard ➡️


Flakiness

e2e/multi-domain/navigation_spec.ts Flakiness
1 delayed navigation > localhost -> foobar, delay in
reporter.hooks.spec.js Flakiness
1 hooks > can rerun without timeout error leaking into next run (due to run restart)

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

Copy link
Contributor

@chrisbreiding chrisbreiding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

<head>
</head>
<body>
<button data-cy="to-localhost" onclick="setTimeout(()=>{window.location.href = 'http://localhost:3500/fixtures/auth/index.html'}, 1500)">navigate to localhost</button>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be a bit easier to read the contents of these functions if we did something like a script tag that has a function that calls the setTimeout navigation

@mjhenkes mjhenkes merged commit 35501bc into feature-multidomain Mar 16, 2022
@mjhenkes mjhenkes deleted the md-delayed-navigation branch March 16, 2022 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: cy.origin Problems or enhancements related to cy.origin command
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants