chore: [Multi-domain] Clean up stability code. #20656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ecBridge Command called.
mjhenkes
added
the
topic: cy.origin
|
Thanks for taking the time to open a PR!
|
mjhenkes
requested review from
chrisbreiding,
mschile,
AtofStryker and
a team
and removed request for
jennifer-shehane and
a team
mjhenkes
commented
Mar 17, 2022
packages/driver/cypress/integration/e2e/multi-domain/navigation_spec.ts
Outdated
Show resolved
Hide resolved
|
Test summary
Run details
View run in Cypress Dashboard ➡️ Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
||||||||||||||||||||||||||||||||||||||||||
…ive (or a timeout will happen)
mjhenkes
changed the title
mjhenkes
commented
Mar 17, 2022
mschile
approved these changes
Mar 18, 2022
chrisbreiding
approved these changes
Mar 18, 2022
mschile
pushed a commit
that referenced
this pull request
Mar 22, 2022
* chore: [Multi-domain] Fix Flake when subdomain loads faster than toSpecBridge Command called. * Add Test * simplify test * Loading a cross domain page won't happen until the spec bridge is active (or a timeout will happen) * Update packages/driver/src/multi-domain/domain_fn.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User facing changelog
n/a
Additional details
On further inspection, we should not get into a state where the AUT loads before the spec bridge is active due to our delaying logic. Given this we can remove some code trying to sync a load even that happened if the page loaded before the specbridge was active.
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?cypress.schema.json?